New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confuse about get_affine_transform function #77

Open

yfthu opened this issue Dec 20, 2021 · 1 comment

yfthu commented Dec 20, 2021

Hello, you have done a great job! However, I'm confused about the get_affine_transform function in mks0601/TF-SimpleHumanPose/main/gen_batch.py

when calcualte src_dir = get_dir([0, src_w * -0.5], rot_rad), I think it should be src_dir = get_dir([src_w * -0.5, 0], rot_rad), because the first index is width.
in your get_affine_transform, if shift=0 in input, only scale[0] is used, scale[1] is not used, I think it is incorrect.

Thank you very much!

Owner

mks0601 commented Dec 20, 2021

For both questions, you are correct. Sorry for the wrong ones :(
To be honest, the codes in this repo are outdated version. You can refer to codes in my recent repo (https://github.com/mks0601/I2L-MeshNet_RELEASE/blob/4c71b89713eccfb893607963696f368f4beb9fa6/common/utils/preprocessing.py#L92).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment