Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pre-merge job to run pylint #13

Open
galv opened this issue Apr 30, 2021 · 2 comments
Open

Add a pre-merge job to run pylint #13

galv opened this issue Apr 30, 2021 · 2 comments

Comments

@galv
Copy link
Collaborator

galv commented Apr 30, 2021

Now that we have several people developing, we should start thinking about adding this. I'm not sure how github does this actually. We can also consider adding a pre-commit git hook as well.

More importantly, we should start running unit tests before each merge.

@Ciroye
Copy link
Collaborator

Ciroye commented Apr 30, 2021

We must define the main factors that we must ensure before making a "pull request". Which are the "scripts" or functions in which we should focus tests before accepting any improvement.

I will be investigating unit tests that allow us to ensure the integrity of the project

@Ciroye Ciroye closed this as completed May 19, 2021
@Ciroye
Copy link
Collaborator

Ciroye commented May 19, 2021

Already implemented Pylint test. The next step implement Bazel in github actions

@Ciroye Ciroye reopened this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants