Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provided step is ignored in coordinate selection #69

Open
observingClouds opened this issue Feb 12, 2025 · 2 comments
Open

Provided step is ignored in coordinate selection #69

observingClouds opened this issue Feb 12, 2025 · 2 comments
Assignees
@matschreiner
Labels
bug Something isn't working

Comments

@observingClouds
Copy link
Contributor

sel_step is not provided to the actual selection:

mllam-data-prep/mllam_data_prep/ops/selection.py

Line 74 in f58cdac

ds = ds.sel({coord: slice(sel_start, sel_end)})

@observingClouds
Copy link
Contributor Author

Sorry @matschreiner, seems like I have a good 👃 today

@observingClouds observingClouds added the bug Something isn't working label Feb 12, 2025
@observingClouds
Copy link
Contributor Author

observingClouds commented Feb 12, 2025 •
edited
Loading

When addressing #68 it would probably be good to also allow for timedelta types in the range section of the configs

observingClouds added a commit to observingClouds/mllam-data-prep that referenced this issue Feb 12, 2025
@observingClouds
quick fix of mllam#69
67d8f44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matschreiner matschreiner

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matschreiner @observingClouds