Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the use of column roles for grouping features #193

Closed
pat-s opened this issue Jun 2, 2022 · 2 comments
Closed

Clarify the use of column roles for grouping features #193

pat-s opened this issue Jun 2, 2022 · 2 comments

Comments

@pat-s
Copy link
Member

pat-s commented Jun 2, 2022

Currently there are multiple ways to do so

  • via coords_as_features (legacy implementation), e.g. in SpCVCoords
  • via $set_column_roles(), e.g. in SptCVCstf and others

Setting a column role for coordinates in SpCVCoords will not change the behaviour, i.e. coordinates stay out of the feature set (which is good).

This should be documented cleary in the mlr3book.

@pat-s pat-s changed the title Clarify the setting of column roles for grouping features Clarify the use of column roles for grouping features Jun 2, 2022
@pat-s
Copy link
Member Author

pat-s commented Jun 7, 2022

We evaluate whwehter space and time should be stored in groups and handled natively by {mlr3}s grouping logic - together with the stratum column role.

The coordinates role might stay.

@pat-s
Copy link
Member Author

pat-s commented Aug 6, 2022

  • coords_as_features is a shortcut for task$set_col_roles(c("x", "y"), role = "feature")
  • Using groups instead of space and time has been rejected internally as it would not work with the current mlr3 API

@pat-s pat-s closed this as completed Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant