Skip to content

Commit 28b78e8

Browse files
committed
Dodge an ancient ksh bug that breaks configure on some platforms.
8.4.10's configure script suddenly started failing on platforms that use older versions of ksh as /bin/sh. It turns out to be a ksh bug that's triggered by here-document delimiters falling across bufferload boundaries: https://mailman.research.att.com/pipermail/ast-developers/2010q4/000797.html Hopefully this will get fixed before we trip over it again, but to make 8.4.10 releasable, add a comment to move the boundaries to dodge the bug. Per buildfarm members koi and warthog, plus a report from Bjorn Munch of the identical failure on Solaris 10.
1 parent c2e412a commit 28b78e8

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

configure

+3
Original file line numberDiff line numberDiff line change
@@ -27415,6 +27415,9 @@ ac_config_headers="$ac_config_headers src/include/pg_config.h"
2741527415
ac_config_headers="$ac_config_headers src/interfaces/ecpg/include/ecpg_config.h"
2741627416

2741727417

27418+
# This comment is to lengthen the configure script to dodge this ksh93 bug:
27419+
# https://mailman.research.att.com/pipermail/ast-developers/2010q4/000797.html
27420+
2741827421
cat >confcache <<\_ACEOF
2741927422
# This file is a shell script that caches the results of configure
2742027423
# tests run on this system so they can be shared between configure

configure.in

+3
Original file line numberDiff line numberDiff line change
@@ -1878,6 +1878,9 @@ echo >src/include/stamp-h
18781878
AC_CONFIG_HEADERS([src/interfaces/ecpg/include/ecpg_config.h],
18791879
[echo >src/interfaces/ecpg/include/stamp-h])
18801880

1881+
# This comment is to lengthen the configure script to dodge this ksh93 bug:
1882+
# https://mailman.research.att.com/pipermail/ast-developers/2010q4/000797.html
1883+
18811884
AC_OUTPUT
18821885

18831886
# Warn about unknown options

0 commit comments

Comments
 (0)