Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmRegister controller and register processor are hard-coded to use modFileRegister #137

Open
martinf55 opened this issue Oct 22, 2018 · 3 comments

Comments

@martinf55
Copy link

Using registry.modFileRegister means activations fail in load balanced environments when the registration request happens on a different server to the activation request.

@Jako
Copy link
Collaborator

Jako commented Oct 23, 2018

Would it i.e. help to make the properties in these lines configurable by a system setting?
https://github.com/modxcms/Login/blob/master/core/components/login/controllers/web/ConfirmRegister.php#L130-L131

Sorry, but I don't have any experience in balanced environments.

@martinf55
Copy link
Author

Yes, I've forked the project, hopefully I can put together a pull request which allows a system setting login.registry_class to override the registry.modFileRegister with registry.modDbRegister.

I've had the modDbRegister working locally, but just bumped into some kind of concurrency issue when on a load-balanced environment (possibly a lingering database lock). Once that's fixed I should have something to PR here.

@Jako
Copy link
Collaborator

Jako commented Oct 23, 2018

Maybe you could ask @opengeek wether he has some tip for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants