Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call recording #161

Open
CodeCracker-oss opened this issue Jan 21, 2023 · 10 comments
Open

Call recording #161

CodeCracker-oss opened this issue Jan 21, 2023 · 10 comments
Labels
feature-request New feature or request

Comments

@CodeCracker-oss
Copy link

Hello,

Would you consider adding a feature to record all incoming/outgoing calls the moment the call is established?

This would avoid having a 3rd party app do this. The only one I know of that is capable of recording signal calls is ACR Cube recorder, but its proprietary, has unneccesary permissions, and ads/trackers which could comprimise the security of signal.

Thank you

@valldrac valldrac added the feature-request New feature or request label Feb 14, 2023
@Ryuo1
Copy link

Ryuo1 commented Feb 16, 2023

It's funny how you think a proprietary call recording app could compromise the security of Signal when recording a call. Because, it completely throws away the point of call encryption in Signal when you are recording a call from it

@CodeCracker-oss
Copy link
Author

CodeCracker-oss commented Feb 16, 2023

@ryu0q As long as my device is secure, no one would be able to view recording anyway. It could also utilize pgp encryption during VOIP call recording for extra security.

With standard phone call recording, the keys to encrypt call are handled by cell provider so they could listen in if they wish, unlike signal. So, depending on your attack vector it wouldn't hurt security.

For me personally, when I make a call where I have to exhange personal info like an SSN for verification at my bank, I will encrypt the recording afterwards or shred it if I don't need it.

@valldrac
Copy link
Member

Would you consider adding a feature to record all incoming/outgoing calls the moment the call is established?

To get a better idea of the use case... Should the app notify the call participants, before the call begins, that the call is recorded?

@valldrac valldrac changed the title [Feature Request] Call recording Call recording Mar 25, 2023
@Ryuo1
Copy link

Ryuo1 commented Mar 25, 2023

Yeah. There should be a big text in red background saying that the call is being recorded. Considering if this ever turns into a feature.

@CodeCracker-oss
Copy link
Author

@valldrac

To get a better idea of the use case... Should the app notify the call participants, before the call begins, that the call is recorded?

Maybe it would be nice to have that as an optional setting. Like for those in countries that are two party consent laws, then a caller wouldn't have to remember to inform the other of the recording.

As I am in the US, and well aware of the legality, this would not be neccessary and may just get annoying.

@h3ph4est7s
Copy link
Contributor

This feature may look simple but i don't think it is. The java part of the app is handling only signaling and state changes as far as i see through the code. The actual audio - video data is handled by RingRTC. Any additions should add code there + new interface changes between native and java, plus ui additions to enable, disable, handle that feature this translates to multiple languages expertise (Java - Kotlin, c++ - rust) and a greater level of complexity - testing. In any case i would like to add on this that when a privacy invading feature is added a counterweight should be added also (please feel free to open another issue for this if needed) a good candidate for that can be this. With some research and the utilization of the pixel tensor processor, this can be integrated and provide a good anonymization layer to the user's voice to counter any recording effort especially from the moment that any notification can be reliably removed from any malicious party. The only thing left is the value of the recorded information but this is out of any technical scope and lies only on the user's discretion.

@schklom
Copy link

schklom commented Mar 28, 2023

may just get annoying

@dhammel There are situations where this is counter-productive. This can be an opt-out option, but forcing this on everyone is very bad. If this is forced, I would rather use a third-party like ACR Cube Recorder.

@CodeCracker-oss
Copy link
Author

@schklom I never mentioned to force anything on anyone, as i've even mentioned it should be optional. Wether its opt-in or opt-out doesn't matter to me personally.

Using something such as ACR is what could actually hurt security/privacy, since the app is proprietary, contains ads and trackers and who knows what else.

@schklom
Copy link

schklom commented Mar 28, 2023

@dhammel I must have misread then, my bad.
I prevent ACR from connecting to the Internet, so no privacy problems. I agree it is not ideal, but I cannot always use a recording method that always warns the other party.

@CodeCracker-oss
Copy link
Author

@schklom I agree with you, sometimes warning the other party is not ideal or may interfere with reson for recording.

I never actually used ACR, I've used a hardware device plugged in via usb-c that records the mic and speakers internally when I know in advance I need to record from VOIP apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Development

No branches or pull requests

6 participants
@h3ph4est7s @valldrac @schklom @CodeCracker-oss @Ryuo1 and others