Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized month names may be problematic #37

Open
eserte opened this issue Mar 19, 2023 · 0 comments
Open

Localized month names may be problematic #37

eserte opened this issue Mar 19, 2023 · 0 comments

Comments

@eserte
Copy link
Contributor

eserte commented Mar 19, 2023

A today's conversion of a fit file using fit2gpx.pl and a German locale created an invalid XML file due to

        <name>Track 19-Mär-23 11:58</name>

where the umlaut-a was in iso-8559-1 encoding, not in utf-8 encoding.

Suggestions:

  • I think ISO8601 datetimes are the best option nowadays. So the strftime format in
    $f_startTime = POSIX::strftime("%d-%b-%y %H:%M", @lt);
    is probably better rewritten to "%FT%T" or so
  • Alternatively keep the %b format, but make sure that it's at some point converted to utf-8, either by using something like binmode(TMP, ':utf8') or Encode::encode_utf8 or so.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant