Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hungarian localization 🇭🇺 #3181

Open
SandorUK opened this issue Nov 7, 2021 · 16 comments
Open

Hungarian localization 🇭🇺 #3181

SandorUK opened this issue Nov 7, 2021 · 16 comments
Assignees
Labels
community i18n Internationalization

Comments

@SandorUK
Copy link

SandorUK commented Nov 7, 2021

🇭🇺 Hungarian Localisation

📝 Localising Display and Keyboard Input language

Plan of action:

  1. Localised display language
  2. Refine display-language localisation
  3. Localise keyboard input language
  4. Glyph inclusion

Font localisation

Based on font supported list of glyphs all Hungarian characters are included https://www.grillitype.com/api/storage/app/uploads/public/5b6/c52/16b/5b6c5216b40a8675629257.pdf

However it appears Űű and Őő while present in the font, they are missing from glyphs included in the system, which requires and update to the list of included glyphs as well.

@SandorUK SandorUK added community i18n Internationalization labels Nov 7, 2021
@SandorUK SandorUK self-assigned this Nov 7, 2021
@SandorUK
Copy link
Author

SandorUK commented Nov 7, 2021

@wojtekidd Hello there, I've started working on localisation. According to https://github.com/mudita/MuditaOS/blob/master/doc/development_workflow.md there should be only one commit in PR. Am I allowed to make as many commits as I need (WIP) on my branch though? I'll squash and rebase before the PR to make it a single commit. I just like to commit on feature branch as I work and if someone joins this will allows them to see the progress.

@SandorUK
Copy link
Author

SandorUK commented Nov 8, 2021

Attempted to do Quick Linux startup.

Environment:

  • Ubuntu 20.0x
  • GCCv10
  • cmake 3.20

Upon execution of build command build Pure consistently receiving this error

[ 29%] Building CXX object module-apps/application-settings/CMakeFiles/application-settings.dir/ApplicationSettings.cpp.o
c++: fatal error: Killed signal terminated program cc1plus
compilation terminated.
make[3]: *** [module-apps/application-settings/CMakeFiles/application-settings.dir/build.make:76: module-apps/application-settings/CMakeFiles/application-settings.dir/ApplicationSettings.cpp.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:11845: module-apps/application-settings/CMakeFiles/application-settings.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:12293: products/PurePhone/CMakeFiles/Pure.dir/rule] Error 2
make: *** [Makefile:3169: Pure] Error 2

@SandorUK
Copy link
Author

SandorUK commented Nov 8, 2021

Attempted to do Quick Linux startup.

Environment:

  • Ubuntu 20.0x
  • GCCv10
  • cmake 3.20

Upon execution of build command build Pure consistently receiving this error

[ 29%] Building CXX object module-apps/application-settings/CMakeFiles/application-settings.dir/ApplicationSettings.cpp.o
c++: fatal error: Killed signal terminated program cc1plus
compilation terminated.
make[3]: *** [module-apps/application-settings/CMakeFiles/application-settings.dir/build.make:76: module-apps/application-settings/CMakeFiles/application-settings.dir/ApplicationSettings.cpp.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:11845: module-apps/application-settings/CMakeFiles/application-settings.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:12293: products/PurePhone/CMakeFiles/Pure.dir/rule] Error 2
make: *** [Makefile:3169: Pure] Error 2

This issue was caused by not enough memory on a virtual machine. The solution was to increase VM RAM to 4 GB.

@SandorUK
Copy link
Author

SandorUK commented Dec 2, 2021

@wojtekidd hello. I've opened branch feature/Hungarian-localization before MuditaOS repo went public, then I was removed from Mudita org as the repo went public. I cannot push to the branch anymore. Do I need a fork now or can you set my permissions for this branch? Thanks.

ERROR: Permission to mudita/MuditaOS.git denied to SandorUK.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@pholat
Copy link
Contributor

pholat commented Dec 2, 2021

  • Am I allowed to make as many commits as I need (WIP) on my branch though?
    Absolutely, this is the best way to go! :)

  • before MuditaOS repo went public
    I assume you still have the changes available locally.

Your changes shouldn't affect any frequently changed code therefore update should be pretty straightforward.
You may either:

  1. use git diff > patch.diff then git apply patch.diff on fresh branch from master
  2. use create a new branch from master, use git cherry-pick on your changes
  3. use git rebase on your branch. This should work just fine. It will show a silly amount of changes, but it shall work just fine

If you do not feel comfortable with actions to be performed - cloning the repository clean, then using git patch would be the easiest way in which you would be in control.

@pholat
Copy link
Contributor

pholat commented Jan 5, 2022

@SandorUK issue closed due to inactivity, please reopen if required.

@pholat pholat closed this as completed Jan 5, 2022
@SandorUK
Copy link
Author

SandorUK commented Jan 5, 2022

@pholat it's been an intense year end at work and Xmas break, I'll re-open as I have work done, but not yet committed due to the protection status of the branch.

@SandorUK
Copy link
Author

SandorUK commented Jan 5, 2022

@pholat could you please re-open as I do not have sufficient permissions to do so (not a member of the org and your closing action overrides my ownership of the issues it seems). Thanks!

@MauPalantir
Copy link

@pholat Hi, what is the status on this issue? We are looking forward to use the phone in Hungarian.

@SandorUK
Copy link
Author

@MauPalantir hey there! I'm the developer who is working on localisation into Hungarian. I'm trying to get this issue re-opened as it was auto-closed. I've done all the translations, but I need help context testing them using simulator. Once the issue is re-opened I will be able to push code and provide instructions for testing.

@SandorUK
Copy link
Author

@SP2FET could you re-open this please?

@MauPalantir
Copy link

@SP2FET can you re-open this issue? we would really like to use mudita in Hungarian.

@SP2FET SP2FET reopened this Jul 19, 2022
@SP2FET
Copy link
Contributor

SP2FET commented Jul 19, 2022

@SandorUK @MauPalantir sorry for the delay - somehow I didn't get any notification that you mentioned me in the comment

@SP2FET
Copy link
Contributor

SP2FET commented Jul 19, 2022

@SandorUK feel free to push the code either to your fork or dedicated branch and play with the simulator!

@SandorUK
Copy link
Author

SandorUK commented Jul 19, 2022 via email

@MauPalantir
Copy link

@SP2FET Thank you very much! @SandorUK if you need any help testing the feature feel free to ping me. Im not a mobile dev, but I guess I can figure it out with enough docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community i18n Internationalization
Projects
Status: Quarantine
Development

No branches or pull requests

4 participants