Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[studio] Data grid density issue #4242

Open
oliviertassinari opened this issue Oct 12, 2024 · 0 comments
Open

[studio] Data grid density issue #4242

oliviertassinari opened this issue Oct 12, 2024 · 0 comments
Labels
design This is about UI or UX design, please involve a designer priority: low To delay as much as possible scope: toolpad-studio Abbreviated to "studio" waiting for 👍 Waiting for upvotes

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 12, 2024

Steps to reproduce

The current row height for the different density settings looks odd. They were first defined with mui/mui-x#567 but they don't seem to work super great. It feels like everything is so big, for example, no mui/mui-public#211, this is not compact, this feels medium size:

SCR-20241012-mfga

A quick benchmark:

-1 Default +1
Elastic 23px 35px 39px
Gmail 28px 40px
Airtable 31px 55px 87px
MUI X 36px (x0.7) 52px (MD spec) 67px (x1.3)

I'm not super clear on either the issue is rooted in Toolpad. It could be the default values of MUI X that are too big, but they are following the Material Design spec, so hard to argue for a change.

At the end of the day, I suspect that it's a problem with Material UI. We should fix mui/material-ui#41579, which Toolpad could then leverage.

Current behavior

No response

Expected behavior

No response

cc @KenanYusuf for awareness.

@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer design This is about UI or UX design, please involve a designer scope: toolpad-studio Abbreviated to "studio" labels Oct 12, 2024
@Janpot Janpot added waiting for 👍 Waiting for upvotes priority: low To delay as much as possible and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer priority: low To delay as much as possible scope: toolpad-studio Abbreviated to "studio" waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

2 participants