Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Input #89

Open
oss92 opened this issue Mar 14, 2016 · 3 comments
Open

File Input #89

oss92 opened this issue Mar 14, 2016 · 3 comments
Labels

Comments

@oss92
Copy link

oss92 commented Mar 14, 2016

Extending the Input to include file uploading would be nice.

What I get now is a warning Failed propType: Invalid proptypeof valuefilesupplied toInput, expected one of ["text","email","url","tel","password"].

Perhaps this could help (Dropify) or this Codepen sample

@amorey
Copy link
Member

amorey commented Mar 20, 2016

@oss92 Apologies for the late reply! I've been traveling this past week.

Our goal is to keep the core MUI library as lightweight as possible and support other components via a plugin system. We haven't started working the plugin system yet but if this is something you'd like to look into, let me know.

@amorey amorey closed this as completed Mar 22, 2016
@amorey amorey reopened this Mar 22, 2016
@amorey amorey added the wontfix label Mar 22, 2016
@oss92
Copy link
Author

oss92 commented Mar 22, 2016

But since it already includes ["text","email","url","tel","password"], doesn't it make sense to only include also file?

Anyways the plugin system sounds good too. Thanks for your reply! 👍

@amorey
Copy link
Member

amorey commented Mar 22, 2016

No prob! Adding "file" to the list would imply that the MUI <Input> component supports file uploading. To use the browser's built-in file upload component you can ignore the MUI component and use the native <input type="file"> element instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants