Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight differences of the focus points displayed in the plugin and the built-in camera screen #176

Open
lethal233 opened this issue Dec 16, 2023 · 13 comments
Assignees

Comments

@lethal233
Copy link

Hi,

Firstly I want to say thanks to your dedicated developers. After successfully installing the plug-in, I saw a slight difference of the focus points displayed in the plugin pop-up and the built-in camera screen. I was just wondering whether this can be accepted or not. If it cannot be accepted, is following the "add your own camera" section the next step?

Camera Model: Sony Alpha 7 C II

Your plugin shows:
image

The built-in screen shows:
IMG_9809

@capricorn8
Copy link
Collaborator

capricorn8 commented Dec 16, 2023

I don't have Sony specific AF knowledge, but the following applies to modern mirrorless cameras in general and should be kept in mind when evaluating the plugin result:

  1. The plugin relies on documented tags from EXIF metadata (maker notes section) to retrieve AF information. If the camera does not maintain these fields properly because it primarily uses other AF related sections in an undocumented part of maker notes the results of camera (or maker's RAW converter) display and plugin may differ.
    I am using OM-1 and can see a similar behavior. For OM-1 predecessors E-M1, E-M5, E-M10 results are identical.

There are other Sony AF visualizers eg. https://github.com/SK-Hardwired/s_afv.
You might want to check if these show differences in AF position as well.

  1. For cameras using contrast AF, the center dot displayed by the plugin is misleading*. The focus point is somewhere inside the red box. Accordingly, on camera display the focus point is somewhere inside the green box. Both red and green boxes in the images do overlap, so in my opinion the difference is acceptable.

*That's why I have removed the center dot for Olympus and OM System cameras. I am neither the inventor/author of the plugin nor do I have specific knowledge about Canon/Nikon/Sony etc. so I didn't want to touch the logic for other camera makers.

@lethal233
Copy link
Author

I don't have Sony specific AF knowledge, but the following applies to modern mirrorless cameras in general and should be kept in mind when evaluating the plugin result:

  1. The plugin relies on documented tags from EXIF metadata (maker notes section) to retrieve AF information. If the camera does not maintain these fields properly because it primarily uses other AF related sections in an undocumented part of maker notes the results of camera (or maker's RAW converter) display and plugin may differ.
    I am using OM-1 and can see a similar behavior. For OM-1 predecessors E-M1, E-M5, E-M10 results are identical.

There are other Sony AF visualizers eg. https://github.com/SK-Hardwired/s_afv. You might want to check if these show differences in AF position as well.

  1. For cameras using contrast AF, the center dot displayed by the plugin is misleading*. The focus point is somewhere inside the red box. Accordingly, on camera display the focus point is somewhere inside the green box. Both red and green boxes in the images do overlap, so in my opinion the difference is acceptable.

*That's why I have removed the center dot for Olympus and OM System cameras. I am neither the inventor/author of the plugin nor do I have specific knowledge about Canon/Nikon/Sony etc. so I didn't want to touch the logic for other camera makers.

Gotcha, thank you very much! I will try the visualizer instead.

@capricorn8 capricorn8 reopened this Feb 22, 2025
@capricorn8
Copy link
Collaborator

capricorn8 commented Feb 22, 2025

I am reopening this fairly old issue.

I am currently working on the plugin not just to make its operation more user-friendly and provide more information to assess the focus results. See latest pre-release and accompanying user documentation.

As far as camera support goes, I'm done with Canon, Nikon, Fuji and Olympus - reviewing the implemented focus point logic and comparing the against the reference apps (NX Studio, DPP, etc.).

Next will be Sony.

I'm not a Sony shooter, so my major source for test images is dpreview galleries.

If you are still interested in this plugin and send me the above image, I will investigate the reason for the deviation. Also thank you for the link to Sony AF visualizer!

@capricorn8 capricorn8 self-assigned this Feb 22, 2025
@ropma
Copy link
Contributor

ropma commented Feb 23, 2025

Hallo Karsten,

here you can find two other Sony picture where there is a slight difference:

https://www.dropbox.com/scl/fo/bwzenzlqw0rf4p3k6g7ts/AO3uRVb89lLUVa8mixKQe5w?rlkey=i04g1j4g9k8uh90qz9dkhtsu3&st=7krlasy9&dl=0

If you need more examples or other AF modes, please tell me.

Regards Roland

@capricorn8
Copy link
Collaborator

Hallo Roland,

I'm confident, that the slight deviation in focus display is fixed - at least for A6xxx, A7 and A7R which are currently under investigation.

Do these screenshots show the expected result?

Image
Image

The same should apply to PDAF point positions.

BTW, is there any way to check focus/PDAF points against a Sony reference display? I have downloaded Imaging Edge, but the viewer doesn't even display the focus points for many images and no PDAF points at all.

The only possibility of comparison I currently have is the SK-Hardwired app mentioned by the TO and here positions perfectly match.

Face detection is also working:

Image
Image

One thing which I don't understand how to handle is the many images captured with AF-S (across various lines and models) that do not have any focus information included. I just cannot believe that AF did accomplish a result here:

Image

@ropma
Copy link
Contributor

ropma commented Feb 23, 2025

Hello Karsten,

you use Imaging Edge for displaying the focus points, but you have activate it (icon left to the histogram):

Image

The focus point on your screenshot are better, but still not the same are in IE (see also the screenshot above).

Focus point are only support for the newer Sony cameras. See readme:

Sony E-Mount cameras
all full frame bodies beginning with α7 III resp. α7R II
APS-C
α6100, α6400, α6500, α6600, ..

This also applies to Imaging Edge.

@capricorn8
Copy link
Collaborator

The issue is not that I didn't know how to activate the focus frame display. IE just doesn't display focus points and face detection frames. E.g. for the image of the woman and the child taken with a 7R IV there is nothing. I have many such images taken with a camera later than the ones mentioned in readme.

You are right that the plugin doesn't display the same information in all instances. The IE display isn't as detailed as the plugin's display. See this example:

Image
Image

The plugin visualizes the information stored in EXIF makernotes. The results are the same as for SK-Hardwired app. For their IE app, Sony might make uses of additional information that has not been decoded yet (or is not even part of EXIF metadata).
For the average camera user, too detailed information might be confusing. However, I don't see how one should easily produce the frames as displayed by IE. If somebody has a got idea, she/he can join this development and implement that.

@ropma
Copy link
Contributor

ropma commented Feb 23, 2025

That's strange.
The focus point are in the EXIF data, because our plugin can display them.

Thus I assume that is a IE problem. I download the raw from the 'woman and the child' and it is a "Reduced-resolution image" . If I use the lower RAW size, I get the same problem. The focus point are not displayed within IE.

@capricorn8
Copy link
Collaborator

If you're interested to use the current version on your images:

My "develop" branch has all the latest changes, the code is a pre-pre-release of V2.5 (only quick regression test pending).

This version includes verified support for all brands/models except Pentax. See changelog.

Be sure to have a look at the user documentation - quite a few things have changed since the original version that existed for many years.

I'm planning to push all the changes to master next week and officially release V2.5.

@ropma
Copy link
Contributor

ropma commented Feb 24, 2025

I synced your develop branch. Looks very promising. I really like the extra infos at the right border.
Thank you

@capricorn8
Copy link
Collaborator

Glad you like it 😊 In fact, overhauling the UI has been much less effort compared to the effort in making Nikon support complete. If you talk about "rocket science" - Nikon AF really is! 😄

@ropma
Copy link
Contributor

ropma commented Feb 27, 2025

.. to the effort in making Nikon support complete. If you talk about "rocket science" - Nikon AF really is! 😄

was is all done by reverse engineering or is there a documentation?

@capricorn8
Copy link
Collaborator

was is all done by reverse engineering or is there a documentation?

No documentation. Reverse engineering supported by fruitful discussions with ExifTool's Nikon expert. Plus, a lot of manual effort to precisely sizing the PDAF pixel points for the various models. Nikon (by default for DSLRs, but also for the PDAF part in Mirrorless) is using a naming scheme like A1, C6, E9 for PD focus points w/o any information on pixel coordinates...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants