From acf1b0f90b4ec934d27fb52ae965ce8e47f944c2 Mon Sep 17 00:00:00 2001 From: James Lee Date: Sat, 29 Aug 2015 17:16:35 +0900 Subject: [PATCH] Fix code styles on MQTT codec classes --- .../handler/codec/mqtt/MqttConnAckVariableHeader.java | 4 +++- .../netty/handler/codec/mqtt/MqttConnectReturnCode.java | 8 ++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnAckVariableHeader.java b/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnAckVariableHeader.java index 75678649c659..474217163947 100644 --- a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnAckVariableHeader.java +++ b/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnAckVariableHeader.java @@ -36,7 +36,9 @@ public MqttConnectReturnCode connectReturnCode() { return connectReturnCode; } - public boolean isSessionPresent() { return sessionPresent; } + public boolean isSessionPresent() { + return sessionPresent; + } @Override public String toString() { diff --git a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnectReturnCode.java b/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnectReturnCode.java index bf43377bed85..16d96f378b20 100644 --- a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnectReturnCode.java +++ b/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnectReturnCode.java @@ -31,14 +31,14 @@ public enum MqttConnectReturnCode { CONNECTION_REFUSED_BAD_USER_NAME_OR_PASSWORD((byte) 0x04), CONNECTION_REFUSED_NOT_AUTHORIZED((byte) 0x05); - private static final Map valueToCodeMap; + private static final Map VALUE_TO_CODE_MAP; static { final Map valueMap = new HashMap(); for (MqttConnectReturnCode code: values()) { valueMap.put(code.byteValue, code); } - valueToCodeMap = Collections.unmodifiableMap(valueMap); + VALUE_TO_CODE_MAP = Collections.unmodifiableMap(valueMap); } private final byte byteValue; @@ -52,8 +52,8 @@ public byte byteValue() { } public static MqttConnectReturnCode valueOf(byte b) { - if (valueToCodeMap.containsKey(b)) { - return valueToCodeMap.get(b); + if (VALUE_TO_CODE_MAP.containsKey(b)) { + return VALUE_TO_CODE_MAP.get(b); } throw new IllegalArgumentException("unknown connect return code: " + (b & 0xFF)); }