Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iroh-relay: support the relay server on a URL prefix #2440

Open
flub opened this issue Jul 1, 2024 · 3 comments
Open

iroh-relay: support the relay server on a URL prefix #2440

flub opened this issue Jul 1, 2024 · 3 comments
Labels
c-iroh c-iroh-relay feat New feature or request

Comments

@flub
Copy link
Contributor

flub commented Jul 1, 2024

Currently we only support a RelayUrl with a toplevel domain name: https://example.com/. Internally this will results in several routes being served, like https://example.com/relay etc.

Perhaps we should consider allowing it to be hosted on any custom path prefix as well: https://example.com/path/prefix/ so that the routes served are "mounted" at this location: https://example.com/path/prefix/relay etc.

This could make sense in some deployments where the same domain wants to host other resources.

@link2xt
Copy link
Contributor

link2xt commented Nov 5, 2024

Would be nice to document all the paths that should be proxied. I proxy /relay as a websocket, but there is also /generate_204 (which, well, generates error 204), /relay/probe (which seems to be unused) and legacy /derp and /derp/probe.

I have proxied only /relay and it seems to work already: deltachat/chatmail#451

@matheus23
Copy link
Contributor

I have proxied only /relay and it seems to work already: deltachat/chatmail#451

/derp is legacy and we only serve it for old clients (iroh-net versions prior to version 0.21)

@flub
Copy link
Contributor Author

flub commented Nov 5, 2024

/relay/probe is used by the https probe which is still stuck in a branch somewhere. Given I'm inclined to change the path of it anyway there's no point to proxy it for now. And even if it existed it might be better to configure the proxy server to respond to it directly because the latency of the response on that path matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-iroh c-iroh-relay feat New feature or request
Projects
Status: No status
Development

No branches or pull requests

3 participants