Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iroh-relay): rate limiting of connections to the relay server #2967

Open
ramfox opened this issue Nov 26, 2024 · 2 comments
Open

feat(iroh-relay): rate limiting of connections to the relay server #2967

ramfox opened this issue Nov 26, 2024 · 2 comments
Labels
c-iroh-relay feat New feature or request

Comments

@ramfox
Copy link
Contributor

ramfox commented Nov 26, 2024

The relay server does currently not have any rate limiting on the number of connections to any of its services (relay/http(s), stun, quic). There should probably be some kind of abuse protection.

Some care needs to be taken however, since by definition the relay is supposed to help NATed clients. So simple per-IP measures are likely to harm legitimate users.

@ramfox ramfox moved this to 📋 Backlog in iroh Nov 26, 2024
@flub flub changed the title feat(iroh-relay): add rate limiting & configuration for rate limiting to the QUIC endpoint in the relay server feat(iroh-relay): rate limiting of connections to the relay server Nov 27, 2024
@flub flub added the feat New feature or request label Nov 27, 2024
@Arqu
Copy link
Collaborator

Arqu commented Dec 3, 2024

Is this close-able now with #2961 merged?

@flub
Copy link
Contributor

flub commented Dec 3, 2024

I don't think so, I think this issue is about the number of connections and connection rate made to the relay server for each service. #2961 is rate-limiting the incoming bandwidth of established connections only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-iroh-relay feat New feature or request
Projects
Status: No status
Development

No branches or pull requests

3 participants