Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing one entry rewrites all other RRs #39

Open
alexs77 opened this issue Jan 19, 2021 · 6 comments
Open

Changing one entry rewrites all other RRs #39

alexs77 opened this issue Jan 19, 2021 · 6 comments

Comments

@alexs77
Copy link

alexs77 commented Jan 19, 2021

I'm managing my domain with terraform and your plugin. In my IaC, I've got something like this:

resource "godaddy_domain_record" "skwar_me" {
    domain    = "skwar.me"

    addresses = []

    record {
        data     = "184.168.131.241"
        name     = "@"
        ttl      = 600
        type     = "A"
    }
    record {
        data     = "184.168.131.241"
        name     = "a"
        type     = "A"
    }
    record {
        data     = "184.168.131.241"
        name     = "godaddy"
        ttl      = 600
        type     = "A"
    }
    #
}

When I now remove the 2nd record (with name = "a"), a terraform plan would show, that ALL the other RRs of that zone would be 1st removed and 2nd added again, with the exact same values.

If the zone is a bit "bigger" (even with just 20+ RRs), it becomes close to impossible to see, what's actually been changed.

@ilons
Copy link

ilons commented Apr 9, 2021

I'm experiencing the same issue, but only for one of my zones in the account, the other one works just fine.
Anyone have an idea of what might cause this?

@ilons
Copy link

ilons commented Apr 9, 2021

@jakob-northvolt: Is this fixed in jakob-northvolt@a0e786c? And if so, when can we expect this out in a release?

@jakob-northvolt
Copy link

@jakob-northvolt: Is this fixed in jakob-northvolt@a0e786c? And if so, when can we expect this out in a release?

Yes it is actually, I meant to make a PR but I got sidetracked with other stuff. I can create a PR during the day.
There is a little caveat though that has to do with Godaddy API limitation of certain records being treated as batch no matter what, I will make a comment here when done, but it does solve this issue to the extent possible with regards to Godaddy API.

@jakob-northvolt
Copy link

Might have some uncommitted stuff still locally so don't rely on the version in the repo just yet. I'll sort it out today at some point.

@jakob-northvolt: Is this fixed in jakob-northvolt@a0e786c? And if so, when can we expect this out in a release?

@ilons
Copy link

ilons commented Apr 9, 2021

@jakob-northvolt: Is this fixed in jakob-northvolt@a0e786c? And if so, when can we expect this out in a release?

Yes it is actually, I meant to make a PR but I got sidetracked with other stuff. I can create a PR during the day.
There is a little caveat though that has to do with Godaddy API limitation of certain records being treated as batch no matter what, I will make a comment here when done, but it does solve this issue to the extent possible with regards to Godaddy API.

Now that is wonderful news! Lets hope those changes can make it into the provider soon :)

@jakob-northvolt
Copy link

jakob-northvolt commented Apr 9, 2021

See pull request:
#42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants