Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button trailing icon #295

Closed
mjablecnik opened this issue Feb 13, 2025 · 2 comments
Closed

Button trailing icon #295

mjablecnik opened this issue Feb 13, 2025 · 2 comments
Assignees
Labels
accepted A valid and reproducible issue bug Something isn't working

Comments

@mjablecnik
Copy link

Steps to reproduce

Hello, I need to add trailing icon into Button.
I found, for button you support only leading icon:

Image

Can you support also trailing icons or widgets same as other design packages?
Thank you

Image

Expected results

    ShadButton(
      onPressed: () {},
      trailing: const Icon(Icons.add),
      child: const Text('Add'),
    ),

Image

Actual results

ShadButton(
  onPressed: () {},
  child: const Text('Login with Email'),
  icon: const Icon(LucideIcons.mail),
),

Image

shadcn_ui version

0.19.3

Platform

MacOS

Code sample

Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration

[Upload media here]

Logs

Logs
[Paste your logs here]

Flutter Doctor output

Doctor output
[Paste your output here]
@mjablecnik mjablecnik added bug Something isn't working triage Issues that need assessment and prioritization labels Feb 13, 2025
@nank1ro
Copy link
Owner

nank1ro commented Feb 13, 2025

There is an open discussion about this here #283

See the current way to move the icon on the trailing side https://flutter-shadcn-ui.mariuti.com/utils/order_policy/

@nank1ro
Copy link
Owner

nank1ro commented Feb 19, 2025

closed by #295

@nank1ro nank1ro closed this as completed Feb 19, 2025
@nank1ro nank1ro added accepted A valid and reproducible issue and removed triage Issues that need assessment and prioritization labels Feb 19, 2025
@nank1ro nank1ro self-assigned this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted A valid and reproducible issue bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants