Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write.nrrd should be able to use header for core fields as well #244

Open
jefferis opened this issue Jun 8, 2015 · 3 comments
Open

write.nrrd should be able to use header for core fields as well #244

jefferis opened this issue Jun 8, 2015 · 3 comments

Comments

@jefferis
Copy link
Collaborator

jefferis commented Jun 8, 2015

Those specified as main arguments should still take priority. Should also normalise argument/field names

e.g.

enc-> encoding
dtype->type 

though for dtype, should probably keep a deprecated alias.

@jefferis
Copy link
Collaborator Author

jefferis commented Jun 8, 2015

May also need to change dtype in write.amiramesh. Or accept that we have dtype which accepts a subset of type names and use header$type to set using any nrrd type name.

@jefferis jefferis changed the title write.nrrd should be able to use header for core fields a well write.nrrd should be able to use header for core fields as well Jun 8, 2015
@jefferis jefferis added this to the 1.8 milestone Jul 8, 2015
@jefferis
Copy link
Collaborator Author

I think that we could have different options for dtype in write.amiramesh and write.nrrd. But the option of setting fancier type values in header$type is also fine I think.

@jefferis
Copy link
Collaborator Author

One issue to think about carefully if this is implemented is handling of default type, endian and encoding values which are carried forwards from nrrds that have been read in with read.im3d. For example if they have been modified the historical default of writing as dtype="float" might be more appropriate than using the original type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant