Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AXIS test failures on HeadlessChrome 65.0.3325 (Mac OS X 10.13.3) #349

Open
rshingleton opened this issue Mar 26, 2018 · 1 comment
Open
Labels

Comments

@rshingleton
Copy link
Contributor

AXIS test failures on HeadlessChrome 65.0.3325 (Mac OS X 10.13.3)
While testing on a Mac I ran into a couple test errors that seem to only be happening on the Mac.

axis.x.tick.width
      indexed x axis and y/y2 axis
        not rotated
          ✔ should construct indexed x axis properly
          ✔ set options axis.x.tick.format
          ✖ should split x axis tick text to multiple lines
          ✔ should construct y axis properly
          ✔ should construct y2 axis properly
          ✔ set options data.columns, big values in y
          ✔ should not split y axis tick text to multiple lines
        rotated
          ✔ should split x axis tick text to multiple lines
          ✔ should not split y axis tick text to multiple lines
      category axis
        not rotated
          ✔ should locate ticks properly
          ✔ should split tick text properly
          ✔ should set tooltip
        rotated
          ✔ should locate ticks on rotated axis properly
          ✖ should split tick text on rotated axis properly
        option used
          as null
            ✔ should split x tick
          as value
            ✔ should split x tick to 2 lines properly
      with axis.x.tick.format
        ✔ should have multiline tick text
      axis.x.tick.format for category type
        ✔ should have multiline tick text
...

SUMMARY:
✔ 487 tests completed
✖ 2 tests failed

FAILED TESTS:
  AXIS
    axis.x.tick.width
      indexed x axis and y/y2 axis
        not rotated
          ✖ should split x axis tick text to multiple lines
            HeadlessChrome 65.0.3325 (Mac OS X 10.13.3)
          AssertionError: expected 'very long tick text' to equal 'very long tick'
              at SVGTSpanElement.<anonymous> (base/spec/internals/axis-spec.js?7dea7151c310b560f8a88af521a2322d4a79d137:36283:35)
              at Selection.__webpack_exports__.a [as each] (base/spec/internals/axis-spec.js?7dea7151c310b560f8a88af521a2322d4a79d137:13795:37)
              at SVGGElement.<anonymous> (base/spec/internals/axis-spec.js?7dea7151c310b560f8a88af521a2322d4a79d137:36280:52)
              at Selection.__webpack_exports__.a [as each] (base/spec/internals/axis-spec.js?7dea7151c310b560f8a88af521a2322d4a79d137:13795:37)
              at Context.<anonymous> (base/spec/internals/axis-spec.js?7dea7151c310b560f8a88af521a2322d4a79d137:36277:49)

      category axis
        rotated
          ✖ should split tick text on rotated axis properly
            HeadlessChrome 65.0.3325 (Mac OS X 10.13.3)
          AssertionError: expected 3 to equal 4
              at Context.<anonymous> (base/spec/internals/axis-spec.js?7dea7151c310b560f8a88af521a2322d4a79d137:36412:34)

Steps to check or reproduce

  • Checkout project on Mac OS
  • npm install
  • npm test
@netil netil added the test label Mar 27, 2018
@netil
Copy link
Member

netil commented Mar 27, 2018

Thanks @rshingleton for reporting.

I used to run tests on Windows and MacOS either and sometimes the error happens in specific env only, due to the difference of the os(or env). For now, required env for tests is CI(which is linux).

I'll look for that, but without in hurry 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants