Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] ForwardAuth OAuth provider that support insecure tls certificates #1024

Open
costrouc opened this issue Feb 3, 2022 · 6 comments
Labels
area: authentication impact: high 🟥 This issue affects most of the nebari users or is a critical issue needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug type: enhancement 💅🏼 New feature or request

Comments

@costrouc
Copy link
Member

costrouc commented Feb 3, 2022

Description

This issue was discovered in #1017. It is related to an issue with traefik forward auth thomseddon/traefik-forward-auth#122. This limits our forward auth to only working with trusted domains. We need to discuss and decide if we stick with traefik forward auth or move towards a more adopted forward auth e.g. https://github.com/oauth2-proxy/oauth2-proxy.

Value/benefit

Transparent authentication is more transparent.

@viniciusdc
Copy link
Contributor

In the meantime, we should put a notice in the docs saying that using lets-encrypt for generating the certs would be the recommended way for a fresh install... @costrouc what do you think?

@dhirschfeld
Copy link

I'm also using thomseddon/traefik-forward-auth and, unfortunately, it seems ~unmaintained.

To work around that issue I add our CA to a custom built image. I also have to build from thomseddon/traefik-forward-auth#49 (comment) as otherwise you can't use it for anything with a path prefix :/

I don't think it's fit for production as-is; particularly being a security sensitive component - you want something well maintained.

So, I'm considering alternative options to provide Azure AD auth for our traefik ingress. I'll check out oauth2-proxy and I'll be interested in your experiences! 👀

@dhirschfeld
Copy link

using lets-encrypt for generating the certs would be the recommended way

Our infra is in a pretty locked down private network so using Lets Encrypt was a non-starter for us.

@costrouc
Copy link
Member Author

@dhirschfeld thanks for joining in the conversation. Yes I agree and do see some issues using this project long term. We will be talking this issue in around 3 months or so. We will make sure to update this issue on what we find.

@dhirschfeld
Copy link

We will make sure to update this issue on what we find.

Thanks! I'm doing some similar stuff to qhub so am very interested in how you're going about things. I'm keeping an eye on development here with a view to hopefully giving it a go at some stage (when I can find the time!)

@trallard trallard added impact: high 🟥 This issue affects most of the nebari users or is a critical issue and removed priority: high labels May 21, 2022
@iameskild
Copy link
Member

I wonder if moving to OAuth2Proxy would resolve this? @viniciusdc perhaps you know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: authentication impact: high 🟥 This issue affects most of the nebari users or is a critical issue needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug type: enhancement 💅🏼 New feature or request
Projects
Status: New 🚦
Development

No branches or pull requests

7 participants