Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - nebari deploy with -o fails in multiple places #1716

Open
pmeier opened this issue Apr 12, 2023 · 2 comments
Open

[BUG] - nebari deploy with -o fails in multiple places #1716

pmeier opened this issue Apr 12, 2023 · 2 comments
Labels
area: nebari-cli needs: PR 📬 This item has been scoped and needs to be worked on type: bug 🐛 Something isn't working

Comments

@pmeier
Copy link
Member

pmeier commented Apr 12, 2023

Describe the bug

The nebari internals ignore the -o / --output setting in multiple places, e.g.

nebari/nebari/render.py

Lines 272 to 274 in daecbcf

output_filename = os.path.join(output_base_dir, filename)
if os.path.isfile(output_filename):
output_files[filename] = hash_file(filename)

nebari/nebari/deploy.py

Lines 48 to 53 in daecbcf

directory = "stages/02-infrastructure"
stage_outputs[directory] = terraform.deploy(
os.path.join(directory, config["provider"]),
input_vars=input_vars.stage_02_infrastructure(stage_outputs, config),
)

Expected behavior

If we provide such an option it should work.

OS and architecture in which you are running Nebari

Linux

How to Reproduce the problem?

Run nebari deploy with -o / --output set to something else than $PWD.

Command output

No response

Versions and dependencies used.

No response

Compute environment

None

Integrations

No response

Anything else?

No response

@pmeier pmeier added needs: triage 🚦 Someone needs to have a look at this issue and triage type: bug 🐛 Something isn't working labels Apr 12, 2023
@pavithraes pavithraes added needs: PR 📬 This item has been scoped and needs to be worked on area: nebari-cli and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels Apr 22, 2023
@pmeier pmeier self-assigned this Apr 23, 2023
@iameskild
Copy link
Member

@pmeier are you still working on this? If not, would it be alright if I took this?

@pmeier pmeier removed their assignment May 16, 2023
@pmeier
Copy link
Member Author

pmeier commented May 16, 2023

Go ahead!

@iameskild iameskild self-assigned this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: nebari-cli needs: PR 📬 This item has been scoped and needs to be worked on type: bug 🐛 Something isn't working
Projects
Status: New 🚦
Development

No branches or pull requests

3 participants