Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classPostfix configuration not working #22

Closed
vgrigoriu opened this issue Mar 9, 2020 · 3 comments
Closed

classPostfix configuration not working #22

vgrigoriu opened this issue Mar 9, 2020 · 3 comments

Comments

@vgrigoriu
Copy link

When I set classPostfix to Hollow, the generated code refers to a StringHollow class (presumably the same thing as HString) but there's no StringHollow class in the code generated. I'm pretty sure I'm using version 1.1.7 of the plugin.

I tried calling HollowAPIGenerator directly, and things seem to work as expected (there's a StringHollow class generated).

Let me know if you need a repro or other details.

@vgrigoriu
Copy link
Author

I discovered that this is fixed by upgrading hollowVersion here. I can provide a PR but I'm not sure how a new version of the plugin is published?

@rpalcolea
Copy link
Member

Hi! thanks for looking into this

I upgraded to latest hollow and released v2.0.0. Should be out in a bit https://travis-ci.org/nebula-plugins/nebula-hollow-plugin/builds/660870112

@vgrigoriu
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants