Skip to content

Commit 9f22a3f

Browse files
committed
Reduce recursion depth in recently-added regression test.
Some buildfarm members fail the test with the original depth of 10 levels, apparently because they are running at the minimum max_stack_depth setting of 100kB and using ~ 10k per recursion level. While it might be interesting to try to figure out why they're eating so much stack, it isn't likely that any fix for that would be back-patchable. So just change the test to recurse only 5 levels. The extra levels don't prove anything correctness-wise anyway.
1 parent 2868b0c commit 9f22a3f

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/test/regress/expected/plpgsql.out

+4-4
Original file line numberDiff line numberDiff line change
@@ -2790,8 +2790,8 @@ DROP FUNCTION nonsimple_expr_test();
27902790
create function recurse(float8) returns float8 as
27912791
$$
27922792
begin
2793-
if ($1 < 10) then
2794-
return sql_recurse($1 + 1);
2793+
if ($1 > 0) then
2794+
return sql_recurse($1 - 1);
27952795
else
27962796
return $1;
27972797
end if;
@@ -2800,10 +2800,10 @@ $$ language plpgsql;
28002800
-- "limit" is to prevent this from being inlined
28012801
create function sql_recurse(float8) returns float8 as
28022802
$$ select recurse($1) limit 1; $$ language sql;
2803-
select recurse(0);
2803+
select recurse(5);
28042804
recurse
28052805
---------
2806-
10
2806+
0
28072807
(1 row)
28082808

28092809
create function error1(text) returns text language sql as

src/test/regress/sql/plpgsql.sql

+3-3
Original file line numberDiff line numberDiff line change
@@ -2345,8 +2345,8 @@ DROP FUNCTION nonsimple_expr_test();
23452345
create function recurse(float8) returns float8 as
23462346
$$
23472347
begin
2348-
if ($1 < 10) then
2349-
return sql_recurse($1 + 1);
2348+
if ($1 > 0) then
2349+
return sql_recurse($1 - 1);
23502350
else
23512351
return $1;
23522352
end if;
@@ -2357,7 +2357,7 @@ $$ language plpgsql;
23572357
create function sql_recurse(float8) returns float8 as
23582358
$$ select recurse($1) limit 1; $$ language sql;
23592359

2360-
select recurse(0);
2360+
select recurse(5);
23612361

23622362
create function error1(text) returns text language sql as
23632363
$$ SELECT relname::text FROM pg_class c WHERE c.oid = $1::regclass $$;

0 commit comments

Comments
 (0)