Skip to content

Commit f655a9f

Browse files
committed
Fix typo in pg_srand48 (srand48 in older branches).
">" should be ">>". This typo results in failure to use all of the bits of the provided seed. This might rise to the level of a security bug if we were relying on srand48 for any security-critical purposes, but we are not --- in fact, it's not used at all unless the platform lacks srandom(), which is improbable. Even on such a platform the exposure seems minimal. Reported privately by Andres Freund.
1 parent cbd5154 commit f655a9f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/port/rand.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ srand48(long seed)
7171
{
7272
_rand48_seed[0] = RAND48_SEED_0;
7373
_rand48_seed[1] = (unsigned short) seed;
74-
_rand48_seed[2] = (unsigned short) (seed > 16);
74+
_rand48_seed[2] = (unsigned short) (seed >> 16);
7575
_rand48_mult[0] = RAND48_MULT_0;
7676
_rand48_mult[1] = RAND48_MULT_1;
7777
_rand48_mult[2] = RAND48_MULT_2;

0 commit comments

Comments
 (0)