Skip to content

feat: verify .netlify doesn't contain sensitive information #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erezrokah opened this issue Mar 22, 2021 · 0 comments
Closed

feat: verify .netlify doesn't contain sensitive information #2039

erezrokah opened this issue Mar 22, 2021 · 0 comments
Labels
area: command: build area: command: init area: command: link type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@erezrokah
Copy link
Contributor

erezrokah commented Mar 22, 2021

Is your feature request related to a problem? Please describe.

Per this comment .netlify can contain sensitive information.

At the moment we have under that folder:

  1. state.json with the linked site id
  2. Auto installed plugins under .netlify/plugins (after running netlify build)
  3. Bundled functions under .netlify/functions (after running netlify build)

None of these is sensitive, but they still should not be committed to the repo.

We should verify the statement in #506 (comment) is still true, and find a better way to prevent users from committing sensitive information as users can also manually update .gitignore.

Describe the solution you'd like

If we do plan to save sensitive I don't think we should have under a folder that can be committed by mistake.
The solution might be verifying we don't save sensitive information under .netlify at the moment and prevent future code changes from doing so.

Describe alternatives you've considered

N/A

Additional context

#2029 (comment)

Can you submit a pull request?

Yes

@erezrokah erezrokah added type: feature code contributing to the implementation of a feature and/or user facing functionality area: command: link area: command: init area: command: build labels Mar 22, 2021
@serhalp serhalp closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: command: build area: command: init area: command: link type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

No branches or pull requests

2 participants