Skip to content

chore: refactor logging #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erezrokah opened this issue Jun 22, 2021 · 3 comments
Closed

chore: refactor logging #2728

erezrokah opened this issue Jun 22, 2021 · 3 comments
Assignees
Labels
type: chore work needed to keep the product and development running smoothly

Comments

@erezrokah
Copy link
Contributor

At the moment we need to pass down the oclif logging utilities down to each function.
That makes it very hard to refactor existing functions and uglifies the code.

We could create a global logging utility/object and initialize it during command initialization.
Then we could expose it to be used from any function simply by requiring it.

Somehow related to #1846

@erezrokah erezrokah added type: feature code contributing to the implementation of a feature and/or user facing functionality type: chore work needed to keep the product and development running smoothly and removed type: feature code contributing to the implementation of a feature and/or user facing functionality labels Jun 22, 2021
@erezrokah erezrokah self-assigned this Jun 22, 2021
@tinfoil-knight
Copy link
Contributor

tinfoil-knight commented Jul 25, 2021

@erezrokah Should I take this one up after #2827 is merged? (Please assign if so.)

Would be refactoring the leftover warn and error utilities.

@erezrokah
Copy link
Contributor Author

@erezrokah Should I take this one up after #2827 is merged? (Please assign if so.)

Yes please, that would be great!

Would be refactoring the leftover warn and error utilities.

💯

@ehmicky
Copy link
Contributor

ehmicky commented Sep 23, 2021

Fixed thanks to @tinfoil-knight! 🎉

@ehmicky ehmicky closed this as completed Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

No branches or pull requests

3 participants