-
Notifications
You must be signed in to change notification settings - Fork 394
Never ending "Waiting for framework" in 19.0.3 #7124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm having the same issue, had to downgrade back to 19.0.2 |
@ndhoule It seems to be an issue with netlify and vite. I put together a very simplistic test case at https://github.com/ffaubert/netlify-cli-test. To reproduce after npm install, run netlify dev and then make a change to public/index.html and you'll see Also new in v19.0.3 at startup I see: That was not there in 19.0.2 Thank you for investigating this! |
@ffaubert Thanks for the repro! I'm seeing the I'll keep you both posted--thanks for your patience in the meantime. |
@Simbul @ffaubert I think I may have a fix for this in #7135. Could you give it a try and let me know if it's fixed? npm i -g [email protected] (Note that this won't fix the |
Thank you @serhalp. Unfortunately, I'm still seeing the same behaviour on the version you specified
When using |
To add more data: I'm still seeing the same behaviour on |
Also, still there in |
It looks like |
Thanks for spotting that @Florian-Mt — that's an embarrassing one! I'll prepare a fix. For some reason I can actually finally repro this issue now, so I'll be able to confirm the fix. |
See: 1. #7026 2. #7131 3. #7124 Oops, I was really overthinking this. All this needs to do is, every time a chunk comes in from the underlying framework dev server, clear the spinner line, write the chunk, then resume the spinner. This wasn't set up right at all, which was obfuscated by the erroneous use of `isSpinning` (see previous commit).
See: 1. #7026 2. #7131 3. #7124 Oops, I was really overthinking this. All this needs to do is, every time a chunk comes in from the underlying framework dev server, clear the spinner line, write the chunk, then resume the spinner. This wasn't set up right at all, which was obfuscated by the erroneous use of `isSpinning` (see previous commit).
See: 1. #7026 2. #7131 3. #7124 Oops, I was really overthinking this. All this needs to do is, every time a chunk comes in from the underlying framework dev server, clear the spinner line, write the chunk, then resume the spinner. This wasn't set up right at all, which was obfuscated by the erroneous use of `isSpinning` (see previous commit).
See: 1. #7026 2. #7131 3. #7124 Oops, I was really overthinking this. All this needs to do is, every time a chunk comes in from the underlying framework dev server, clear the spinner line, write the chunk, then resume the spinner. This wasn't set up right at all, which was obfuscated by the erroneous use of `isSpinning` (see previous commit).
…t") (#7242) * fix: fix framework server loading spinner rendering This is a regression in the loading spinner shown before "Waiting for framework port", introduced in 19.0.3. * fix: fix framework server spinner See: 1. #7026 2. #7131 3. #7124 Oops, I was really overthinking this. All this needs to do is, every time a chunk comes in from the underlying framework dev server, clear the spinner line, write the chunk, then resume the spinner. This wasn't set up right at all, which was obfuscated by the erroneous use of `isSpinning` (see previous commit).
* fix: fix framework server loading spinner rendering This is a regression in the loading spinner shown before "Waiting for framework port", introduced in 19.0.3. * fix: fix framework server spinner See: 1. #7026 2. #7131 3. #7124 Oops, I was really overthinking this. All this needs to do is, every time a chunk comes in from the underlying framework dev server, clear the spinner line, write the chunk, then resume the spinner. This wasn't set up right at all, which was obfuscated by the erroneous use of `isSpinning` (see previous commit). * fix: remove "Netlify Dev" prefix from deploy log * fix(dev): polish and improve dev command - Reworded messages for clarity and consistency - I think "Netlify Dev" was a vestige of Netlify CLI's predecessor...? In any case, I dropped this wording. - e.g. Starting Netlify Dev with Astro → Starting Astro dev server - e.g. Waiting for framework port 4321 → Waiting for Astro dev server to be ready on port 4321 - Removed the "🔸 Netlify Dev 🔸" first line (doesn't seem to add anything) - Attempted to address the common confusion around the two printed URLs (our dev server + framework server): - more distinctive box - 'inverted' colour on the URL (cyan background) to make it stand out the most - changed `Server now ready on http...` to `Local dev server ready: http...` - Attempted to address the common confusion around this message: `✔ Waiting for framework port 4321. This can be configured using the 'targetPort' property in the netlify.toml` - (Users often think this is an error message. I don't blame them.) - I changed this to `Waiting for Astro dev server to be ready on port 4321` (where Astro is the framework name) - I added logic so that after 5 seconds of waiting the message changes to `Still waiting for server on port 4321 to be ready. Are you sure this is the correct port for your Astro site? Change this with the targetPort option in your netlify.toml.`. - Collapse "Injected env var" messages into a single line per source - ◈ → ⬥ * fix: revert the framework server log prefix for now
Hey folks, this should be finally fixed in 21.0.0. Thanks for bearing with us! |
Describe the bug
Since upgrading to 19.0.3,
netlify dev
is constantly showing the following message, with a spinner on the left:Running the same command with 19.0.2 does not result in the same behaviour. In fact, the wait seems to be over pretty quickly:
This is printed out before the message saying
Server now ready on http://localhost:8888
Steps to reproduce
netlify dev
Configuration
Environment
The text was updated successfully, but these errors were encountered: