Skip to content

Pass the --dir CLI flag to @netlify/config #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ehmicky opened this issue Jun 25, 2020 · 1 comment
Closed

Pass the --dir CLI flag to @netlify/config #961

ehmicky opened this issue Jun 25, 2020 · 1 comment
Labels
area: command: deploy good first issue low-priority technical-debt type: chore work needed to keep the product and development running smoothly

Comments

@ehmicky
Copy link
Contributor

ehmicky commented Jun 25, 2020

The deploy and dev commands use a --dir CLI flag, representing the build.publish directory.

This flag should be passed to @netlify/config --inlineConfig.publish {dir}

Those CLI commands should then use the returned config.build.publish value instead of the --dir CLI flag. This is because @netlify/config does more logic to retrieve the publish directory.

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Jun 25, 2020
@Benaiah Benaiah assigned Benaiah and unassigned Benaiah Jul 16, 2020
@erquhart erquhart linked a pull request Jul 23, 2020 that will close this issue
@ehmicky
Copy link
Contributor Author

ehmicky commented Aug 10, 2020

Some work was started at #1010, but the PR has been closed since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: command: deploy good first issue low-priority technical-debt type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants