Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[broken thing] customer unable to see explorers profile #518

Open
wein-hillary opened this issue Oct 25, 2021 · 8 comments
Open

[broken thing] customer unable to see explorers profile #518

wein-hillary opened this issue Oct 25, 2021 · 8 comments
Assignees
Labels
mscw: must type: bug code to address defects in shipped code type: chore work needed to keep the product and development running smoothly

Comments

@wein-hillary
Copy link

What needs fixed?
This customer is unable to see their Jamstack Explorers profile. They have included a series of screenshots of what they see and when they see it.

They say "these errors happen under explorers.netlify.com/profile. I’m using Windos10 (original), conecting from Spain. I tried accessing the profile with and without the “cache” enabled in Chrome’s DevTools > Network, but the bug shows anyway. I was not in incognito mode. I tried accessing with Firefox 92.0 (64bit) and Chrome 63.0.x (64.bit)."

Communication from Support surrounding issue:

  1. https://netlify.slack.com/archives/CCC1HDWQY/p1631638526104700
  2. https://netlify.slack.com/archives/C016VMDSEJG/p1634929577001000
@wein-hillary wein-hillary added type: chore work needed to keep the product and development running smoothly mscw: must type: bug code to address defects in shipped code labels Oct 25, 2021
@wein-hillary
Copy link
Author

(Not sure what mscw:must is, tag auto added. I will leave it until a member of DevEx determines if it is necessary.)

@zachleat
Copy link
Contributor

zachleat commented Oct 28, 2021

I can reproduce this

image

maybe related to vercel/next.js#16850 ?

@zachleat
Copy link
Contributor

Got this running the project locally:

image

@zachleat
Copy link
Contributor

Looks like this was introduced by 859c848#diff-c919a6612353db575a3e855e9f751a5b27414e6ba55a75c8c614582ee973514f

based on this preliminary research I think @bencodezen or @tzmanics might be the best person to look at this

https://github.com/netlify/explorers/blame/main/src/components/UserMissionInfo.js#L19

@zachleat
Copy link
Contributor

I would note that changing {mission.instructors[0]} to {mission.instructor} fixes the issue on this page specifically but I don’t think this is in spirit with the changes made in the original PR for the feature at #515

@tzmanics
Copy link
Contributor

looking into in now, thanks for digging into it @wein-hillary & @zachleat !

@wein-hillary
Copy link
Author

Thank you so so much, @tzmanics and @zachleat!

@bencodezen bencodezen self-assigned this Oct 29, 2021
@bencodezen
Copy link
Contributor

So the proper fix would be to figure out why only one instructor is being passed down into the Author, but given that the entire page is broken, reverting it to single author is the best solution to iterate on. Let me know if y'all have any questions in the meantime!

bencodezen added a commit that referenced this issue Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mscw: must type: bug code to address defects in shipped code type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

No branches or pull requests

4 participants