Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error allows re-sharing in the sharing feature. #14287

Open
4 tasks done
buidanhnam opened this issue Jan 2, 2025 · 2 comments
Open
4 tasks done

Error allows re-sharing in the sharing feature. #14287

buidanhnam opened this issue Jan 2, 2025 · 2 comments
Assignees
Labels

Comments

@buidanhnam
Copy link

buidanhnam commented Jan 2, 2025

⚠️ Before posting ⚠️

  • This is a bug, not a question or an enhancement.
  • I've searched for similar issues and didn't find a duplicate.
  • I've written a clear and descriptive title for this issue, not just "Bug" or "Crash".
  • I agree to follow Nextcloud's Code of Conduct.

Steps to reproduce

Step 1: Open the details of the folder/file.
Step 2: Select the "Sharing" tab.
Step 3: Share permissions with the specified user.
Step 4: Select permissions in the "Share Permissions" section and also check "Allow re-sharing" in the advanced options.

Expected behaviour

"Allow re-sharing" is an advanced option and does not affect the permissions already selected in the "Share Permissions" section.

Actual behaviour

the "Allow re-sharing" permission is presented as an advanced option.
However, in the code logic, if the "Allow re-sharing" permission is selected, all other permissions under "Share permissions" are ignored.

Android version

13

Device brand and model

Samsung

Stock or custom OS?

Stock

Nextcloud android app version

3.30.6

Nextcloud server version

30300690

Using a reverse proxy?

I don't know

Android logs

No response

Server error logs

Additional information

I noticed that if the "Allow re-sharing" option is "isChecked," other permissions are ignored.

binding.shareProcessAllowResharingCheckbox.isChecked -> getReSharePermission()

Image

@buidanhnam buidanhnam changed the title Logical error allows re-sharing in the sharing feature. Error allows re-sharing in the sharing feature. Jan 2, 2025
@tobiasKaminsky
Copy link
Member

I cannot reproduce it

  • create a folder

  • share to an user

  • select "view only" and "allow resharing"
    --> user can only see files, and reshare

  • create a folder

  • share to an user

  • select "view only"
    --> user can only see files, and no reshare

@buidanhnam
Copy link
Author

@tobiasKaminsky
The error occurs when you select "Allow upload and editing" (or anything other than "view only") in the "Share Permissions" section.

You may encounter the following issues:

  • The permissions displayed in the "Sharing" tab will be set to "view only."
  • when edit permissions, the "Allow upload and editing" option you previously selected will not be applied. Instead, "view only" will be selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants