Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy email images through HTTPS to fix mixed content #10

Open
nicholaschiang opened this issue Apr 4, 2021 · 0 comments
Open

Proxy email images through HTTPS to fix mixed content #10

nicholaschiang opened this issue Apr 4, 2021 · 0 comments
Assignees
@nicholaschiang
Labels
feature New feature or request p3 Normal priority tasks

Comments

@nicholaschiang
Copy link
Owner

nicholaschiang commented Apr 4, 2021 •
edited
Loading

Right now, certain emails use HTTP to serve their images. We want to--just like Gmail--proxy those images through HTTPS so that we don't trigger a mixed content warning from the user's browser (which gets rid of the HTTPS "lock" symbol):

Parts of this page are not secure (such as the images).
A gray padlock with an orange or yellow triangle indicates that Firefox is not blocking insecure passive content, such as images. By default, Firefox does not block mixed passive content; you will simply see a warning that the page isn't fully secure. Attackers may be able to manipulate parts of the page like displaying misleading or inappropriate content, but they should not be able to steal your personal data from the site.
@nicholaschiang nicholaschiang self-assigned this Apr 27, 2021
nicholaschiang added a commit that referenced this issue May 5, 2021
@nicholaschiang
wip: parse Gmail data into models on back-end
c54dbac 
Related to #11, #10, #7, and #5 because this will allow us to further
manipulate the raw Gmail API data (e.g. by sanitizing it, proxying
images through HTTPS) and save our own metadata about it (e.g. the
scroll position or archive status).
@nicholaschiang nicholaschiang added feature New feature or request p3 Normal priority tasks labels May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicholaschiang nicholaschiang

Labels
feature New feature or request p3 Normal priority tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicholaschiang