Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spinner isn't always cleared from the screen #1338

Open
daylinmorgan opened this issue Jan 23, 2025 · 5 comments
Open

spinner isn't always cleared from the screen #1338

daylinmorgan opened this issue Jan 23, 2025 · 5 comments

Comments

@daylinmorgan
Copy link
Contributor

When running nimble -v there is a leftover working <spinner>.

$ nimble -v
    Working ⣯
nimble v0.16.4 compiled at 2025-01-23 19:34:26
@daylinmorgan
Copy link
Contributor Author

relatedly when using nimble list --ver the spinner interrupts the output

Image

@xTrayambak
Copy link
Contributor

It also makes it really hard to debug things as it's constantly clearing the last line.

@elcritch Is there a way for you to reimplement this without it being so obstructive? Perhaps you should disable it entirely in debug builds, whilst you're at it.

@elcritch
Copy link
Contributor

elcritch commented Feb 5, 2025

relatedly when using nimble list --ver the spinner interrupts the output

Makes sense, I'll look into clearing those up when I get back to some Nimble PRs.

@elcritch
Copy link
Contributor

elcritch commented Feb 5, 2025

It also makes it really hard to debug things as it's constantly clearing the last line.

It only clears lines with the spinner on them.

@elcritch Is there a way for you to reimplement this without it being so obstructive? Perhaps you should disable it entirely in debug builds, whilst you're at it.

Adding an option to disable it for a build would be pretty simple change. I'm sure you could make a PR for that.

@daylinmorgan
Copy link
Contributor Author

It would also be nicer (but not necessary and I imagine non-trivial with the existing nimble log output setup) for the spinner to actually spin by using a different thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants