Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependecies that use forge aliases do not appear in lock file #1341

Open
ire4ever1190 opened this issue Jan 26, 2025 · 4 comments
Open

Dependecies that use forge aliases do not appear in lock file #1341

ire4ever1190 opened this issue Jan 26, 2025 · 4 comments

Comments

@ire4ever1190
Copy link
Contributor

When using forge aliases, the dependencies do not appear in lock files

Example nimble file

# Package

version       = "0.1.0"
author        = "Jake Leahy"
description   = "A new awesome nimble package"
license       = "MIT"
srcDir        = "src"


# Dependencies

requires "nim >= 2.3.1"
requires "gh:ire4ever1190/tree >= 0.1.0"

Running nimble.lock produces this lock file

{
  "version": 2,
  "packages": {},
  "tasks": {}
}
@xTrayambak
Copy link
Contributor

The thing is, I implemented forge aliases in a way that requires special handling in every place that dependency names are being dealt with.

I'm checking out how to fix this right now.

@xTrayambak
Copy link
Contributor

I found the cause. The SAT solver does not account for forge aliases correctly.

@ire4ever1190
Copy link
Contributor Author

The thing is, I implemented forge aliases in a way that requires special handling in every place that dependency names are being dealt with.

I'm checking out how to fix this right now.

Would it work if the aliases were expanded when they are initially read from the nimble file? So that it doesn't need to be handled everywhere?

@xTrayambak
Copy link
Contributor

xTrayambak commented Feb 6, 2025

It would, probably. But it kind of ruins the entire point of the feature for me. I took this feature out of Nix because I really liked how clear and concise it was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants