Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global setting to enable all shell integrations for a given shell #2023

Open
berbiche opened this issue May 18, 2021 · 4 comments
Open

Global setting to enable all shell integrations for a given shell #2023

berbiche opened this issue May 18, 2021 · 4 comments
Labels

Comments

@berbiche
Copy link
Member

Issue description

Taken from #1809 (comment).

The change is quite simple but tedious:

  1. Add a new option for each shell under their respective module i.e. programs.fish.enableAllIntegrations (option name to be revisited).
  2. Change every enable${SHELL}Integrations's default value to that of programs.${SHELL}.enableAllIntegrations i.e. default = config.programs.${SHELL}.enableAllIntegrations.

The last step is the tedious one because they are many instances of enable${SHELL}Integrations in the config.

@berbiche berbiche changed the title Global settings to enable all shell integrations for a given shell Global setting to enable all shell integrations for a given shell May 18, 2021
@rycee
Copy link
Member

rycee commented May 19, 2021

Is it common enough that a user would like to disable all shell integrations? I would imagine that the common case is that you want to disable specific ones.

@berbiche
Copy link
Member Author

Is it common enough that a user would like to disable all shell integrations? I would imagine that the common case is that you want to disable specific ones.

This is also my case for most programs I have enabled.
I proposed setting it to false to keep the current behavior.

@stale
Copy link

stale bot commented Aug 24, 2021

Thank you for your contribution! I marked this issue as stale due to inactivity. If this remains inactive for another 7 days, I will close this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

  • If this is resolved, please consider closing it so that the maintainers know not to focus on this.
  • If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

  • If you are also experiencing this issue, please add details of your situation to help with the debugging process.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

If you have nothing of substance to add, please refrain from commenting and allow the bot close the issue. Also, don't be afraid to manually close an issue, even if it holds valuable information.

Closed issues stay in the system for people to search, read, cross-reference, or even reopen--nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.

@stale stale bot added the status: stale label Aug 24, 2021
@berbiche berbiche added the pinned Prevent marking as stale label Aug 24, 2021
@stale stale bot removed the status: stale label Aug 24, 2021
@berbiche
Copy link
Member Author

This is in my todo-list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants