Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a Prometheus /metrics HTTP endpoint #9

Open
nlewo opened this issue Mar 7, 2024 · 4 comments
Open

Expose a Prometheus /metrics HTTP endpoint #9

nlewo opened this issue Mar 7, 2024 · 4 comments

Comments

@nlewo
Copy link
Owner

nlewo commented Mar 7, 2024

Do not hesitate to propose comin metrics you would like to see exposed.

@nlewo
Copy link
Owner Author

nlewo commented Mar 12, 2024

Users would like to get the last deployed commit id and the last deployment status.

Maybe you could start to expose such kind of metrics:

comin_deployment_info{revision="git-commit-hash", status="succeeded|failed"} = 1

Note, i'm not sure this metric follows Prometheus good practices...

@jpds
Copy link
Contributor

jpds commented Mar 30, 2024

Would be good to have the epoch timestamps of when the remotes were last fetched and when the last config update was applied.

@charlot-shaw
Copy link

How long the update took, maybe how much memory it consumed as well. I've had builds fail on low memory environments because they tried to build a large package.

@tcurdt
Copy link

tcurdt commented Dec 2, 2024

I see it's implemented already

https://github.com/nlewo/comin/blob/main/internal/http/http.go#L40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants