From 89c3bba8e71dcfbf8c9734815e9dc64d865c5b46 Mon Sep 17 00:00:00 2001
From: Joshua Holbrook <josh.holbrook@gmail.com>
Date: Tue, 4 Oct 2011 12:50:01 -0700
Subject: [PATCH 1/5] [ux] treeToHTML sorts the table of contents in a
 reasonable manner.

---
 lib/helpers.js | 55 ++++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 47 insertions(+), 8 deletions(-)

diff --git a/lib/helpers.js b/lib/helpers.js
index 562101f..c8d7371 100644
--- a/lib/helpers.js
+++ b/lib/helpers.js
@@ -85,17 +85,56 @@ helpers.filesToTree = function(files){
 
 helpers.treeToHTML = function(values, parent) {
 
-   var str = '<ul>';
+  var str = '<ul>';
+
+  //
+  // Sort the keys here for a reasonable ToC layout.
+  //
+  Object.keys(values).sort( function (a,b) {
+
+    // These items should be listed *first*.
+    var first = [
+      'getting-started',
+      'intermediate',
+      'advanced',
+      'javascript-conventions'
+    ];
+
+    // These items should be listed *last*.
+    var last = [
+      'cryptography'
+    ];
+
+    // Handles the case where a and/or b is in the "first" list.
+    if ( -~first.indexOf(a) || -~first.indexOf(b) ) {
+      return -~first.indexOf(a) ? (
+        -~first.indexOf(b)
+          ? first.indexOf(a) - first.indexOf(b)
+          : -1
+      ) : 1
+    };
 
-   for(var key in values){
+    // Handles the case where a and/or b is in the "last" list.
+    if ( -~last.indexOf(a) || -~last.indexOf(b) ) {
+      return -~last.indexOf(a) ? (
+        -~last.indexOf(b)
+          ? last.indexOf(a) - last.indexOf(b)
+          : 1
+      ) : -1
+    }
 
-     if(typeof values[key]=='object' && values[key] != null){
-       var newParent = parent || '';
-       newParent = newParent + '/' + key;
-       var link = '/articles' + newParent;
-       str+='<li><a href="' + link + '">'+key.replace(/-/g, ' ')+'</a>' +helpers.treeToHTML(values[key], newParent)+'</li>';
-     }
+    // Handles "default" case.
+    return a > b ? 1 : (a < b ? -1 : 0);
+
+  }).forEach( function(key) {
+
+    if (typeof values[key]=='object' && values[key] != null){
+      var newParent = parent || '';
+      newParent = newParent + '/' + key;
+      var link = '/articles' + newParent;
+      str+='<li><a href="' + link + '">'+key.replace(/-/g, ' ')+'</a>' +helpers.treeToHTML(values[key], newParent)+'</li>';
     }
+  });
 
    str+='</ul>';
 

From e6bc15b7b047f9ed7b067cd8c8eb4d3c66a3ec6f Mon Sep 17 00:00:00 2001
From: Joshua Holbrook <josh.holbrook@gmail.com>
Date: Tue, 4 Oct 2011 13:36:52 -0700
Subject: [PATCH 2/5] [minor] Moved toc sort function to a helper.

---
 lib/helpers.js | 79 +++++++++++++++++++++++++++-----------------------
 1 file changed, 42 insertions(+), 37 deletions(-)

diff --git a/lib/helpers.js b/lib/helpers.js
index c8d7371..2e21d96 100644
--- a/lib/helpers.js
+++ b/lib/helpers.js
@@ -83,6 +83,47 @@ helpers.filesToTree = function(files){
   
 }
 
+//
+// Function to use with sorting the ToC.
+//
+helpers.tocSort = function (a, b) {
+
+  // These items should be listed *first*.
+  var first = [
+    'getting-started',
+    'intermediate',
+    'advanced',
+    'javascript-conventions'
+  ];
+
+  // These items should be listed *last*.
+  var last = [
+    'cryptography'
+  ];
+
+  // Handles the case where a and/or b is in the "first" list.
+  if ( -~first.indexOf(a) || -~first.indexOf(b) ) {
+    return -~first.indexOf(a) ? (
+      -~first.indexOf(b)
+        ? first.indexOf(a) - first.indexOf(b)
+        : -1
+    ) : 1
+  };
+
+  // Handles the case where a and/or b is in the "last" list.
+  if ( -~last.indexOf(a) || -~last.indexOf(b) ) {
+    return -~last.indexOf(a) ? (
+      -~last.indexOf(b)
+        ? last.indexOf(a) - last.indexOf(b)
+        : 1
+    ) : -1
+  }
+
+  // Handles "default" case.
+  return a > b ? 1 : (a < b ? -1 : 0);
+
+};
+
 helpers.treeToHTML = function(values, parent) {
 
   var str = '<ul>';
@@ -90,43 +131,7 @@ helpers.treeToHTML = function(values, parent) {
   //
   // Sort the keys here for a reasonable ToC layout.
   //
-  Object.keys(values).sort( function (a,b) {
-
-    // These items should be listed *first*.
-    var first = [
-      'getting-started',
-      'intermediate',
-      'advanced',
-      'javascript-conventions'
-    ];
-
-    // These items should be listed *last*.
-    var last = [
-      'cryptography'
-    ];
-
-    // Handles the case where a and/or b is in the "first" list.
-    if ( -~first.indexOf(a) || -~first.indexOf(b) ) {
-      return -~first.indexOf(a) ? (
-        -~first.indexOf(b)
-          ? first.indexOf(a) - first.indexOf(b)
-          : -1
-      ) : 1
-    };
-
-    // Handles the case where a and/or b is in the "last" list.
-    if ( -~last.indexOf(a) || -~last.indexOf(b) ) {
-      return -~last.indexOf(a) ? (
-        -~last.indexOf(b)
-          ? last.indexOf(a) - last.indexOf(b)
-          : 1
-      ) : -1
-    }
-
-    // Handles "default" case.
-    return a > b ? 1 : (a < b ? -1 : 0);
-
-  }).forEach( function(key) {
+  Object.keys(values).sort(helpers.tocSort).forEach( function(key) {
 
     if (typeof values[key]=='object' && values[key] != null){
       var newParent = parent || '';

From 1b27eedbd5f4f244c057cfe6cc09f7ee09494f68 Mon Sep 17 00:00:00 2001
From: Joshua Holbrook <josh.holbrook@gmail.com>
Date: Wed, 28 Sep 2011 14:00:24 -0700
Subject: [PATCH 3/5] [ux] "Edit this page on github" button now points to the
 relevant fork/edit github url

---
 theme/article.html | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/theme/article.html b/theme/article.html
index f8e31f1..9183afa 100644
--- a/theme/article.html
+++ b/theme/article.html
@@ -22,6 +22,15 @@
     })();
 
   </script>
+
+  <script type="text/javascript">
+    //This changes the "edit this page" link to go to the "fork and edit" url of the docs.
+    document.ready = function () {
+        var edit = document.getElementById("edit");
+        edit.innerHTML = "<a href='https://github.com/nodejitsu/docs/edit/master/"+window.location.pathname+"/article.md'>Edit this page on GitHub</a>";
+    }
+  </script>
+
 </head>
 <body>
   <header>

From ea448236cdfdd7ac0f34705c586e6c43bf173def Mon Sep 17 00:00:00 2001
From: Joshua Holbrook <josh.holbrook@gmail.com>
Date: Tue, 4 Oct 2011 14:23:56 -0700
Subject: [PATCH 4/5] [fix] div id=edit for "edit this page" link modification
 behavior, remove an extra slash.

---
 theme/article.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/theme/article.html b/theme/article.html
index 9183afa..94d43b7 100644
--- a/theme/article.html
+++ b/theme/article.html
@@ -27,14 +27,14 @@
     //This changes the "edit this page" link to go to the "fork and edit" url of the docs.
     document.ready = function () {
         var edit = document.getElementById("edit");
-        edit.innerHTML = "<a href='https://github.com/nodejitsu/docs/edit/master/"+window.location.pathname+"/article.md'>Edit this page on GitHub</a>";
+        edit.innerHTML = "<a href='https://github.com/nodejitsu/docs/edit/master"+window.location.pathname+"/article.md'>Edit this page on GitHub</a>";
     }
   </script>
 
 </head>
 <body>
   <header>
-    <div class="link"><a href="http://github.com/nodejitsu/docs">Edit this page on GitHub</a></div>
+    <div class="link" id="edit"><a href="http://github.com/nodejitsu/docs">Edit this page on GitHub</a></div>
     <div class="title">docs.nodejitsu.com</div>
   </header>
 

From 5ca328a3a79f691eca83829498ca1ad2f640aa6c Mon Sep 17 00:00:00 2001
From: Joshua Holbrook <josh.holbrook@gmail.com>
Date: Tue, 4 Oct 2011 15:21:10 -0700
Subject: [PATCH 5/5] [ux][fix] Chose a different ToC order. Also, wrote
 cleaner, working sort code.

---
 lib/helpers.js | 45 ++++++++++++++++++++++++++++-----------------
 1 file changed, 28 insertions(+), 17 deletions(-)

diff --git a/lib/helpers.js b/lib/helpers.js
index 2e21d96..144781d 100644
--- a/lib/helpers.js
+++ b/lib/helpers.js
@@ -87,41 +87,52 @@ helpers.filesToTree = function(files){
 // Function to use with sorting the ToC.
 //
 helpers.tocSort = function (a, b) {
+  // For future reference, here is the list from the top-level.
+  /*[
+    'cryptography',
+    'advanced',
+    'intermediate',
+    'errors',
+    'file-system',
+    'javascript-conventions',
+    'child-processes',
+    'command-line',
+    'REPL',
+    'getting-started',
+    'HTTP' ]
+  */
 
   // These items should be listed *first*.
   var first = [
     'getting-started',
-    'intermediate',
-    'advanced',
     'javascript-conventions'
   ];
 
   // These items should be listed *last*.
   var last = [
+    'intermediate',
+    'advanced',
     'cryptography'
   ];
 
+  //a > b: --> 1
+
   // Handles the case where a and/or b is in the "first" list.
   if ( -~first.indexOf(a) || -~first.indexOf(b) ) {
-    return -~first.indexOf(a) ? (
-      -~first.indexOf(b)
-        ? first.indexOf(a) - first.indexOf(b)
-        : -1
-    ) : 1
-  };
-
-  // Handles the case where a and/or b is in the "last" list.
+
+    return ( -~first.indexOf(a) && -~first.indexOf(b) )
+      ? (first.indexOf(a) - first.indexOf(b))
+      : ( -~first.indexOf(a) ? -1 : 1);
+
+  }
+
   if ( -~last.indexOf(a) || -~last.indexOf(b) ) {
-    return -~last.indexOf(a) ? (
-      -~last.indexOf(b)
-        ? last.indexOf(a) - last.indexOf(b)
-        : 1
-    ) : -1
+    return (-~last.indexOf(a) && -~last.indexOf(b))
+      ? (last.indexOf(a) - last.indexOf(b))
+      : ( -~last.indexOf(a) ? 1 : -1);
   }
 
-  // Handles "default" case.
   return a > b ? 1 : (a < b ? -1 : 0);
-
 };
 
 helpers.treeToHTML = function(values, parent) {