Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize example Dockerfiles #181

Open
ayildirim21 opened this issue Jul 11, 2024 · 5 comments
Open

Optimize example Dockerfiles #181

ayildirim21 opened this issue Jul 11, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@ayildirim21
Copy link
Member

Summary

The example images are quite large in size, and take a while to build. We should optimize this to reduce both size and build time. Considered solution: Build dependencies in a virtualenv in the builder layer, and copy over to the runner.

Use Cases

When building example images


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@ayildirim21 ayildirim21 added the enhancement New feature or request label Jul 11, 2024
@vigith
Copy link
Member

vigith commented Jul 11, 2024

@ab93 any other suggestions ?

@ab93
Copy link
Member

ab93 commented Jul 11, 2024

@ab93 any other suggestions ?

Yes we should do something along the lines of: https://github.com/ab93/dockerdemo/blob/main/Dockerfile

@vigith
Copy link
Member

vigith commented Jul 12, 2024

Yes we should do something along the lines of: https://github.com/ab93/dockerdemo/blob/main/Dockerfile

lol, that is too much for examples :)

@ab93
Copy link
Member

ab93 commented Jul 12, 2024

I think you got overwhelmed there 🙂
It's not hard, and the dockerfile will be very short for our use case. Numalogic dockerfile is also a good example.

@kohlisid
Copy link
Contributor

kohlisid commented Jul 12, 2024

Did optimize docker file a bit for the recent intuit builds! Will do some further research and go through the examples provided by @ab93 too.

@ayildirim21 if you're interested in working on this as well let me know!

@kohlisid kohlisid self-assigned this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants