This repository has been archived by the owner on Aug 29, 2022. It is now read-only.

No JS files in Assets #37

Closed

nyccto-rapicastillo opened this issue Jul 28, 2021 · 0 comments · Fixed by #46 or #50

Labels

Contributor

nyccto-rapicastillo commented Jul 28, 2021 •

edited

Loading

I don't think a .js file should be in assets, and if classnames are too long we should probably leverage SCSS extensions/inheritance.

https://github.com/nyc-cto/feedback-module/blob/7bab1610136d81e4d0f466a563951fd491100e33/feedback-module/src/assets/styling_classnames.js#L1-L30

Also constants.js isn't an "asset"

https://github.com/nyc-cto/feedback-module/blob/7bab1610136d81e4d0f466a563951fd491100e33/feedback-module/src/assets/constants.js#L1-L76

The text was updated successfully, but these errors were encountered:

nyccto-rapicastillo added the Code Review label

This was linked to pull requests Jul 29, 2021

Re-organizing files according to Rapi's suggestions #46

Merged

styling updates #50

Merged

michellexliu closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.