Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GitHub releases for starter kyts in kyt-cli setup #526

Open
Jasu opened this issue Aug 11, 2017 · 1 comment
Open

Add support for GitHub releases for starter kyts in kyt-cli setup #526

Jasu opened this issue Aug 11, 2017 · 1 comment

Comments

@Jasu
Copy link

Jasu commented Aug 11, 2017

Versions of kyt, node, OS

kyt-cli: 0.28.4, node: v8.2.1, Linux

Bug or Feature?

Feature request: kyt-cli setup to be able to use a GitHub release as a starter-kyt, instead of using the default branch.
This could be implemented either by

  • supporting git tags/branches with the -r flag, or
  • supporting local .zip files with the --local-path flag

Current Behavior

  • kyt-cli -r git@... clones the repo with its default branch with no option to specify the branch or tag.
  • kyt-cli --local-path kyt.zip copies the path recursively, with no special behavior if the path points to a zip file.

Desired Behavior

kyt-cli -r git@... -b 0.4.1 could call git clone -b 0.4.1 git@... and/or
kyt-cli --local-path kyt-starter-0.3.0.zip could unzip kyt-starter-0.3.0.zip into the project folder, assuming that the starter-kyt is contained in a directory named kyt-starter-0.3.0

Alternatively, kyt-cli could support passing arbitrary arguments to git clone, e.g. by
kyt-cli -r git@... -- -b 0.4.1 --recurse-submodules or kyt-cli -r git@... --git-extra-args "-b 0.4.1,--recurse-submodules"

@delambo
Copy link
Member

delambo commented Aug 11, 2017

Thanks for bringing this up. I think I like you alternative - support for git clone arguments - better. We're using simple-git which supports options.

I think we could deprecate --local-path and use a new param like you suggested to pass in a comma-delimited list of clone options:

kyt-cli setup -r git@remote --clone-options="-b 0.4.1,--recurse-submodules"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants