Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include cmake generator for Visual Studio 2022 in build examples #2026

Open
willihay opened this issue Oct 10, 2022 · 0 comments
Open

Include cmake generator for Visual Studio 2022 in build examples #2026

willihay opened this issue Oct 10, 2022 · 0 comments
Labels
kind/documentation Categorizes issue or PR as related to documentation. kind/enhancement Enhancement to an existing feature priority/critical Critical priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@willihay
Copy link
Contributor

Describe the issue briefly

When showing an example of a cmake build command, 2 tabs are usually shown: Windows and Linux. In the Windows example, the generator is shown for Visual Studio 2019: -G "Visual Studio 16". A third tab should be added for Visual Studio 2022: -G "Visual Studio 17".

The tab labels should change. Suggestion:

Tab 1 Tab 2 Tab 3
Windows + VS 2019 Windows + VS 2022 Linux + Ninja

Which page(s) / section(s) are affected?

Many. Refer to the files changed in this similar PR: #1997.

Does this work have an engineering dependency? What is it?

stabilization/2210

@willihay willihay added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 10, 2022
@chanmosq chanmosq added kind/enhancement Enhancement to an existing feature kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 12, 2022
@chanmosq chanmosq added the priority/critical Critical priority. Must be actively worked on as someone's top priority right now. label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. kind/enhancement Enhancement to an existing feature priority/critical Critical priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Backlog
Development

No branches or pull requests

2 participants