Add obsctl metrics ui command
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
approved these changes
Aug 22, 2022
| var err error | ||
| switch runtime.GOOS { | ||
| case "windows": | ||
| err = exec.Command("rundll32", "url.dll,FileProtocolHandler", url).Run() |
There was a problem hiding this comment.
That's some mastership in hackery 🙈
There was a problem hiding this comment.
Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new command
obsctl metrics ui, which starts up a proxy server using current "context".The proxy server runs on
localhost:8080by default and proxies requests to the current "context" Observatorium API. And it prefixes /api/metrics/v1 path for each request it proxies. This ensures that Thanos Query UI is able to load all the information it needs to display by making requests to localhost.Server is shutdown when a cancellation signal is received.
This can also be extended to other resource types like logs and traces later on!