Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintenance feature request: CI testing of some of our reverse dependencies #183

Closed
gasche opened this issue Mar 14, 2019 · 2 comments
Closed

maintenance feature request: CI testing of some of our reverse dependencies #183

gasche opened this issue Mar 14, 2019 · 2 comments

Comments

@gasche
Copy link
Contributor

gasche commented Mar 14, 2019

It would be nice if our CI would test the build of some of our reverse depencies (after pinning ppx_deriving), for example a couple plugins and a couple users of plugins. This could help us detecting breakage earlier in the release cycle.

(I don't have the knowledge of the best way to do that in immediate memory, so please feel free to point at an example of other project that does this, or even send a PR. Which reverse dependencies we use may depend on the opam-repository-fixing that we are in the process of doing in preparation for the 4.3 release, so I think we could wait to decide this after the release is out.)
thierry-martinez added a commit to thierry-martinez/ppx_deriving that referenced this issue May 24, 2020
@thierry-martinez
Fix ocaml-ppx#183 (pre-ppxlib only): CI testing for our reverse depen…
0d7bc9c 
…dencies

This should implement @gasche suggestion:
ocaml-ppx#183

We should do that for `master` as well (I expect there will be
more failures there!) but I begin here.
@thierry-martinez thierry-martinez mentioned this issue May 24, 2020
Closed
thierry-martinez added a commit that referenced this issue May 25, 2020
@thierry-martinez
Merge pull request #227 from thierry-martinez/pre-ppxlib.revdeps
0f3809a 
Fix #183 (pre-ppxlib only): CI testing for our reverse dependencies (again!)
@shonfeder
Copy link
Contributor

Looks to be closed by #227

@gasche gasche closed this as completed Sep 30, 2021
@gasche
Copy link
Contributor Author

gasche commented Sep 30, 2021

Indeed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gasche @shonfeder