Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentSymbol missing elements #1449

Open
trefis opened this issue Jan 17, 2025 · 0 comments
Open

documentSymbol missing elements #1449

trefis opened this issue Jan 17, 2025 · 0 comments

Comments

@trefis
Copy link

trefis commented Jan 17, 2025

I use the documentSymbol request to move around in .ml buffers, and just noticed that it ignores classes and class types.
Cf.

(module_decl_document_symbol pmd)
| Psig_recmodule modules ->
List.iter modules ~f:(iterator.module_declaration iterator)
| Psig_modtype decl ->
descend
(fun () -> Ast_iterator.default_iterator.module_type_declaration iterator decl)
(module_type_decl_symbol decl)
| _ -> Ast_iterator.default_iterator.signature_item iterator item
in

The linked sample concerns signature items, but the same wildcard pattern is present a few lines down for structure items.

I haven't checked if items other than classes (types) are missing, though removing the wildcard pattern should answer that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant