Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error for IMGUI_VERSION_NUM < 18837 #50

Closed
mgerhardy opened this issue May 17, 2024 · 1 comment
Closed

Compile error for IMGUI_VERSION_NUM < 18837 #50

mgerhardy opened this issue May 17, 2024 · 1 comment

Comments

@mgerhardy
Copy link

#if IMGUI_VERSION_NUM >= 18837
    bool run = ImGui::Button("Run") || ImGui::Shortcut(ImGuiMod_Ctrl | ImGuiKey_R);
#else
    bool = ImGui::Button("Run");
#endif

the variable is missing here - this is in imgui_te_ui.cpp line 283

ocornut added a commit that referenced this issue May 17, 2024
@ocornut
Copy link
Owner

ocornut commented May 17, 2024

Thank you!
I have pushed a series of fixes 291b9b8 to compile latest test engine with 18837 .
Not that test suite is not exercised without it would be too much code to keep latest test suite run on older imgui.

Please note that as per https://github.com/ocornut/imgui_test_engine/wiki/Overview :

It is expected that updates to imgui and imgui_test_engine are synchronized to similar dates (old versions of imgui_test_engine may not work with newer versions of Dear ImGui, and vice-versa).

So while we'll be putting some effort to ensure it mostly/hopefully work, it's possible that we occasionally encounter imgui/ side changes that are too difficult to maintain old version support in test_engine/ and then an imgui update would be required to match.

@ocornut ocornut closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants