From 4610615b7c51556d34cc6418bc492bf0d307c416 Mon Sep 17 00:00:00 2001 From: cowboycito Date: Tue, 3 Jan 2023 20:53:42 -0300 Subject: [PATCH] PR comments --- desktop/main.js | 8 ++++---- src/components/DeeplinkWrapper/deeplinkRoutes.js | 10 ---------- src/components/DeeplinkWrapper/index.website.js | 1 - src/languages/es.js | 1 - 4 files changed, 4 insertions(+), 16 deletions(-) diff --git a/desktop/main.js b/desktop/main.js index b3e1869e1a7f..82953da44a68 100644 --- a/desktop/main.js +++ b/desktop/main.js @@ -481,12 +481,12 @@ const mainWindow = (() => { // After initializing and configuring the browser window, load the compiled JavaScript .then((browserWindowRef) => { loadURL(browserWindow).then(() => { - if (deeplinkUrl) { - browserWindow.loadURL(deeplinkUrl); - browserWindow.show(); + if (!deeplinkUrl) { + return; } - return undefined; + browserWindow.loadURL(deeplinkUrl); + browserWindow.show(); }); return browserWindowRef; diff --git a/src/components/DeeplinkWrapper/deeplinkRoutes.js b/src/components/DeeplinkWrapper/deeplinkRoutes.js index fa5d1a69802c..2e41db1a48cf 100644 --- a/src/components/DeeplinkWrapper/deeplinkRoutes.js +++ b/src/components/DeeplinkWrapper/deeplinkRoutes.js @@ -5,52 +5,42 @@ export default [ { // /reports/* pattern: `/${ROUTES.REPORT}($|(//*))`, - comment: 'Reports', }, { // /settings/* pattern: `/${ROUTES.SETTINGS}($|(//*))`, - comment: 'Profile and app settings', }, { // /setpassword/* pattern: '/setpassword($|(//*))', - comment: 'Passoword setup', }, { // /details/* pattern: `/${ROUTES.DETAILS}($|(//*))`, - comment: 'Details of another users', }, { // /v/* pattern: '/v($|(//*))', - comment: 'Account validation', }, { // /bank-account/* pattern: `/${ROUTES.BANK_ACCOUNT}($|(//*))`, - comment: 'Bank account setup and its steps', }, { // /iou/* pattern: '/iou($|(//*))', - comment: 'I Owe You reports', }, { // /enable-payments/* pattern: `/${ROUTES.ENABLE_PAYMENTS}($|(//*))`, - comment: 'Payments setup', }, { // /statements/* pattern: '/statements($|(//*))', - comment: 'Wallet statements', }, { // /concierge/* pattern: `/${ROUTES.CONCIERGE}($|(//*))`, - comment: 'Concierge', }, ]; diff --git a/src/components/DeeplinkWrapper/index.website.js b/src/components/DeeplinkWrapper/index.website.js index f54ad7c071dc..513d7463e6b5 100644 --- a/src/components/DeeplinkWrapper/index.website.js +++ b/src/components/DeeplinkWrapper/index.website.js @@ -57,7 +57,6 @@ class DeeplinkWrapper extends PureComponent { if (matchedRoute) { this.setState({deeplinkMatch: true}); - this.openRouteInDesktopApp(); } else { this.setState({deeplinkMatch: false}); diff --git a/src/languages/es.js b/src/languages/es.js index f67b366daa12..6391ac7abd23 100644 --- a/src/languages/es.js +++ b/src/languages/es.js @@ -140,7 +140,6 @@ export default { updatePrompt: 'Existe una nueva versión de esta aplicación.\nActualiza ahora or reinicia la aplicación más tarde para recibir la última versión.', }, deeplinkWrapper: { - // TODO: translate to spanish launching: 'Cargando Expensify', redirectedToDesktopApp: 'Te hemos redirigido a la aplicación de escritorio.', youCanAlso: 'También puedes',