Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Newtonsoft.Json to System.Text.Json #518

Open
Christian-Oleson opened this issue Nov 8, 2021 · 2 comments
Open

Migrate from Newtonsoft.Json to System.Text.Json #518

Christian-Oleson opened this issue Nov 8, 2021 · 2 comments

Comments

@Christian-Oleson
Copy link
Contributor

Christian-Oleson commented Nov 8, 2021

User story

As a user, I would like to depend as little on third-party dependencies as possible. For this reason, I would like to move from Newtonsoft.Json to System.Text.Json.

Proposed solution

Replace Newtonsoft.Json with System.Text.Json

Alternatives considered

N/a

Additional information

I believe that this issue (#515) would not be present if we were referencing System.Text.Json. Likewise, I've had a hard time with that particular issue in the code. Something about Newtonsoft with the Okta client is giving me a ton of problems, even after downgrading, making me think we would be better migrating off of it.

@bryanapellanes-okta
Copy link
Contributor

@Christian-Oleson,
Thanks for reaching out! We will review your request internally and reply here.

@rcollette
Copy link

Seriously, System.Text.Json has been out for years. Newtonsoft is not compatible with JSON serialization source generators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants