Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running unblob twice is a bit too silent #986

Closed
e3krisztian opened this issue Oct 18, 2024 · 2 comments
Closed

Running unblob twice is a bit too silent #986

e3krisztian opened this issue Oct 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@e3krisztian
Copy link
Contributor

Describe the bug
When the output directory exists (unblob is called twice), it will exit without any output, except: there is a quick flash.
The exit code will be 1.

To Reproduce
Steps to reproduce the behavior:

  1. Run unblob some.zip twice
  2. The second run will be very quick, and the output will be empty

Expected behavior
The second output should say, that something is wrong.
When run in verbose mode (unblob some.zip -v), the last line is approximately

... [error    ] Skipped: extraction directory exists extract_dir=some.zip_extract pid=...
@e3krisztian e3krisztian added the bug Something isn't working label Oct 18, 2024
@qkaiser
Copy link
Contributor

qkaiser commented Dec 4, 2024

@e3krisztian this got fixed by #1017, correct ?

@qkaiser
Copy link
Contributor

qkaiser commented Feb 11, 2025

Actually fixed:

uv run unblob /tmp/apple.zip 

╭───────────────────────────────────────────────────────────────────────────────────── unblob (25.1.8) ─────────────────────────────────────────────────────────────────────────────────────╮
│ Output path: /home/quentin/unblob/apple.zip_extract                                                                                                                                       │
│ Extracted files: 5                                                                                                                                                                        │
│ Extracted directories: 1                                                                                                                                                                  │
│ Extracted links: 0                                                                                                                                                                        │
│ Extraction directory size: 670.00 B                                                                                                                                                       │
╰───────────────────────────────────────────────────────────────────────────────────────── Summary ─────────────────────────────────────────────────────────────────────────────────────────╯
        Chunks distribution        
┏━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━┓
┃ Chunk type ┃   Size   ┃  Ratio  ┃
┡━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━┩
│ ZIP        │ 642.00 B │ 100.00% │
│ UNKNOWN    │  0.00 B  │  0.00%  │
└────────────┴──────────┴─────────┘
Chunk identification ratio: 100.00%
uv run unblob /tmp/apple.zip

╭───────────────────────────────────────────────────────────────────────────────────── unblob (25.1.8) ─────────────────────────────────────────────────────────────────────────────────────╮
│ Output path: None                                                                                                                                                                         │
│ Extracted files: 1                                                                                                                                                                        │
│ Extracted directories: 0                                                                                                                                                                  │
│ Extracted links: 0                                                                                                                                                                        │
│ Extraction directory size: 642.00 B                                                                                                                                                       │
╰───────────────────────────────────────────────────────────────────────────────────────── Summary ─────────────────────────────────────────────────────────────────────────────────────────╯
        Chunks distribution        
┏━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━┓
┃ Chunk type ┃   Size   ┃  Ratio  ┃
┡━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━┩
│ ZIP        │ 642.00 B │ 100.00% │
│ UNKNOWN    │  0.00 B  │  0.00%  │
└────────────┴──────────┴─────────┘
Chunk identification ratio: 100.00%
               Encountered errors               
┏━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Severity       ┃ Name                        ┃
┡━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ Severity.ERROR │ OutputDirectoryExistsReport │
└────────────────┴─────────────────────────────┘

@qkaiser qkaiser closed this as completed Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants