Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated code issues - first round #1

Closed
18 tasks done
koczkatamas opened this issue Sep 30, 2017 · 0 comments
Closed
18 tasks done

Generated code issues - first round #1

koczkatamas opened this issue Sep 30, 2017 · 0 comments

Comments

@koczkatamas
Copy link
Collaborator

koczkatamas commented Sep 30, 2017 •
edited
Loading

  • Go: non-primitive fields should be pointer types
  • Java: one public class per file
  • Java: fix fast compilation's loading issue
  • Java: import java.util.ArrayList & import java.util.Arrays
  • Java / Generic: use converted type: Onearray arr -> ArrayList<Integer>
  • Java: arr[i] -> arr.get(i)
  • Perl: arrays should be prefixed with @ and not $
  • Swift: set field type
  • Swift: find out how to handle optional values
  • Swift: non-mutated fields should be let and not var (or disable warning?)
  • Swift: i++ -> i += 1
  • Swift: remove semicolons (;)?
  • TS/JS: non-mutated fields should be const and not let (low prio)
  • C++: non-primitive fields should be pointer types
  • C++: auto arr = std::make_shared<std::vector<int>>(std::vector<int>({ 1, 2 }));
  • C++: item access: (*arr)[i]
  • Fix double semicolon (;) issues
  • Perl, Python, Ruby: convert comments to #-type ones
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@koczkatamas