Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateRangeAggregation - "keyed" option support missing #283

Open
pmishev opened this issue Jun 25, 2019 · 2 comments
Open

DateRangeAggregation - "keyed" option support missing #283

pmishev opened this issue Jun 25, 2019 · 2 comments

Comments

@pmishev
Copy link
Contributor

pmishev commented Jun 25, 2019

The DateRangeAggregation can't be passed the keyed option currently.
https://www.elastic.co/guide/en/elasticsearch/reference/6.3/search-aggregations-bucket-daterange-aggregation.html#_keyed_response_4

Looks like this has been reported before in #237, but never fixed.
@saimaz
Copy link
Member

saimaz commented Jun 27, 2019

yep, keyed is not implemented, would be awesome if you could add a PR to 5.x branch by introducing this option. It's pretty simple to add though.

pmishev added a commit to pmishev/ElasticsearchDSL that referenced this issue Jun 27, 2019
@pmishev
Added support for 'keyed' option to DateRangeAggregation (ongr-io#283)
5ada41e
pmishev added a commit to pmishev/ElasticsearchDSL that referenced this issue Jun 27, 2019
@pmishev
Added support for 'keyed' option to DateRangeAggregation (ongr-io#283)
13a8d42
@pmishev
Copy link
Contributor Author

pmishev commented Jun 27, 2019

Sorry, did it from master in a hurry. Hope it's all right

pmishev added a commit to pmishev/ElasticsearchDSL that referenced this issue Jun 27, 2019
@pmishev
Added support for 'keyed' option to DateRangeAggregation (ongr-io#283)
4256f9c
saimaz pushed a commit that referenced this issue Jun 27, 2019
@pmishev @saimaz
Added support for 'keyed' option to DateRangeAggregation (#283) (#287)
c8a2073
@dependabot dependabot bot mentioned this issue Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saimaz @pmishev