Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven RemoveProperty - does not clean up empty properties tag #3231

Closed
nmck257 opened this issue May 10, 2023 · 3 comments
Closed

Maven RemoveProperty - does not clean up empty properties tag #3231

nmck257 opened this issue May 10, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nmck257
Copy link
Collaborator

nmck257 commented May 10, 2023

When RemoveProperty removes the last/only property in a pom.xml, then it would be nice if it also removed the empty <properties> tag. The existing recipe logic is trivial and does not attempt to handle this case.

@timtebeek
Copy link
Contributor

timtebeek commented May 14, 2023

Ideally tackled by calling out to the dedicated recipe in

Through something like

doAfterVisit(new RemoveEmptyXmlTags().getVisitor());

@timtebeek timtebeek added the enhancement New feature or request label May 14, 2023
@timtebeek timtebeek added the good first issue Good for newcomers label Aug 25, 2024
@nielsdebruin
Copy link

Am I correct in thinking 9fed57a resolves this issue?

@timtebeek
Copy link
Contributor

Indeed that's tackled since! Thanks for helping clear out the backlog. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

3 participants